From patchwork Fri Mar 6 23:46:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tthayer@opensource.altera.com X-Patchwork-Id: 5958121 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B22049F373 for ; Fri, 6 Mar 2015 23:46:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E4ABA20390 for ; Fri, 6 Mar 2015 23:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB81B20397 for ; Fri, 6 Mar 2015 23:46:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752638AbbCFXqW (ORCPT ); Fri, 6 Mar 2015 18:46:22 -0500 Received: from mail-bn1on0089.outbound.protection.outlook.com ([157.56.110.89]:13236 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752333AbbCFXqV (ORCPT ); Fri, 6 Mar 2015 18:46:21 -0500 Received: from tthayer-HP-Z620-Ubuntu.altera.com (64.129.157.38) by BLUPR03MB423.namprd03.prod.outlook.com (10.141.78.150) with Microsoft SMTP Server (TLS) id 15.1.106.11; Fri, 6 Mar 2015 23:46:15 +0000 From: To: , , , , , , , CC: , , , , , , , , , , Andy Shevchenko Subject: [RFC/PATCHv2 1/3] spi: dw-spi: Single Register read to clear IRQs Date: Fri, 6 Mar 2015 17:46:32 -0600 Message-ID: <1425685594-26595-2-git-send-email-tthayer@opensource.altera.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1425685594-26595-1-git-send-email-tthayer@opensource.altera.com> References: <1425685594-26595-1-git-send-email-tthayer@opensource.altera.com> MIME-Version: 1.0 X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY2PR06CA062.namprd06.prod.outlook.com (10.141.250.180) To BLUPR03MB423.namprd03.prod.outlook.com (10.141.78.150) Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB423; X-Forefront-Antispam-Report: BMV:1; SFV:NSPM; SFS:(10009020)(6009001)(76176999)(66066001)(50986999)(47776003)(86152002)(87976001)(229853001)(33646002)(2201001)(92566002)(77156002)(62966003)(122386002)(50466002)(19580395003)(42186005)(46102003)(86362001)(40100003)(19580405001)(50226001)(48376002)(2950100001)(53416004)(77096005); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB423; H:tthayer-HP-Z620-Ubuntu.altera.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5002008)(5005006); SRVR:BLUPR03MB423; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB423; X-Forefront-PRVS: 05079D8470 X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2015 23:46:15.7542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB423 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Thor Thayer Instead of clearing the RxU, RxO, and TxO IRQs individually with 3 register reads, a single read of the ICR register will do the same thing. Signed-off-by: Thor Thayer Signed-off-by: Andy Shevchenko Acked-by: Andy Shevchenko --- drivers/spi/spi-dw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index 950bc50..c5fa2be 100644 --- a/drivers/spi/spi-dw.c +++ b/drivers/spi/spi-dw.c @@ -258,9 +258,7 @@ static irqreturn_t interrupt_transfer(struct dw_spi *dws) /* Error handling */ if (irq_status & (SPI_INT_TXOI | SPI_INT_RXOI | SPI_INT_RXUI)) { - dw_readw(dws, DW_SPI_TXOICR); - dw_readw(dws, DW_SPI_RXOICR); - dw_readw(dws, DW_SPI_RXUICR); + dw_readw(dws, DW_SPI_ICR); int_error_stop(dws, "interrupt_transfer: fifo overrun/underrun"); return IRQ_HANDLED; }