From patchwork Wed Apr 8 11:20:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 6178711 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 880F2BF4A6 for ; Wed, 8 Apr 2015 11:25:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B7D712012D for ; Wed, 8 Apr 2015 11:25:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C302D2011E for ; Wed, 8 Apr 2015 11:25:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753902AbbDHLVs (ORCPT ); Wed, 8 Apr 2015 07:21:48 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:36511 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753893AbbDHLVo (ORCPT ); Wed, 8 Apr 2015 07:21:44 -0400 Received: by pabsx10 with SMTP id sx10so111814747pab.3; Wed, 08 Apr 2015 04:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=m+mXR9x0mSz38QoMJH3z2RUTbikhC+fit6mMP0+ElDA=; b=QD1rT9MXZ8J5dXsqouEGlFBjPCWSVaF5RXsrBjdpJWWwYp6+jh5uc8ZjCOUWh4cXu4 MfC6egq9WWfQh9naKgjKzusrm7VHy5Um8KNJhlxi/DSm0ONBstJsY5X0VwWnzOgrGptx FKJ+kpEKxans2dmkzV6i6wehePupXl8L7otJUt4bExU4tCPZugCiyV3NWKioebbgCUtX NIZvhYS0SSvDubqucDj1yu5hJli1HpQMcFk9hLGybNuhzg5YhuF04u7uEGhI0vSJXh6c PhNbR972oEJ/iCnxF9ZMSM7+o81GR1jZzXgYrOZCQ99KhL2BIuefdHMJ1hUIv/rbD+iK fu4A== X-Received: by 10.70.118.36 with SMTP id kj4mr29780101pdb.52.1428492103415; Wed, 08 Apr 2015 04:21:43 -0700 (PDT) Received: from localhost.localdomain ([122.169.147.27]) by mx.google.com with ESMTPSA id og11sm10973411pdb.91.2015.04.08.04.21.37 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 08 Apr 2015 04:21:42 -0700 (PDT) From: Sudip Mukherjee To: Arnd Bergmann , Greg Kroah-Hartman , Jean Delvare , Wolfram Sang , Rodolfo Giometti , "James E.J. Bottomley" , Mark Brown , Willy Tarreau , Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-spi@vger.kernel.org, devel@driverdev.osuosl.org, alsa-devel@alsa-project.org, Sudip Mukherjee Subject: [PATCH 07/14] [SCSI] ppa: return proper error values from attach Date: Wed, 8 Apr 2015 16:50:33 +0530 Message-Id: <1428492040-5581-8-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1428492040-5581-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1428492040-5581-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB, T_DKIM_INVALID, T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/scsi/ppa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.c index 1db8b26..48898ec 100644 --- a/drivers/scsi/ppa.c +++ b/drivers/scsi/ppa.c @@ -1090,9 +1090,9 @@ out: return err; } -static void ppa_attach(struct parport *pb) +static int ppa_attach(struct parport *pb) { - __ppa_attach(pb); + return __ppa_attach(pb); } static void ppa_detach(struct parport *pb)