From patchwork Tue Aug 4 06:09:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Boichat X-Patchwork-Id: 6934191 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 22BF89F373 for ; Tue, 4 Aug 2015 06:10:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4CFBD20626 for ; Tue, 4 Aug 2015 06:10:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B211D2063B for ; Tue, 4 Aug 2015 06:10:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753670AbbHDGKQ (ORCPT ); Tue, 4 Aug 2015 02:10:16 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36771 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753608AbbHDGKN (ORCPT ); Tue, 4 Aug 2015 02:10:13 -0400 Received: by pacgq8 with SMTP id gq8so42709389pac.3 for ; Mon, 03 Aug 2015 23:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2zop3sDwB50HHRKMN7LlslwssJ6LpKeor+GcPJgHpAE=; b=bFgHA7YywMX5Vpv6gbUNinqU6wHDVXmLFlb60nSrFbnO1SVG7R4Hxnde342GX9QW81 iWFe9qgJXykSSC6Q8DrlASpBiSnCQ+aQC+TawvUYs8WCfgkvEgUrDUS0ZSPcHlJT2i+M XW8dmcCwWybdfOulRViPXtgsYBJhF6eh7GOmk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2zop3sDwB50HHRKMN7LlslwssJ6LpKeor+GcPJgHpAE=; b=RJFIXPeDrbBpm/AUgUwWLUf8ksjHVuBW7vYn5/beGb79DuDgEqLy2jlgXqjq1ntAZT QRf2Q2vdD0qbZHL74cuWN62aN6akSEvXuHY474uzYpYW+SgXQNjhnC6ZNHs8/FpWJZ3u 6NIjS9AtoyCD0Y5wWneDVgPNkB174QS37g4SEh8B1yNS9CzRRSsofQ1zoREJI/tHWedE qxkcHh64sJoKp+Dkfc5mdS1E/u6EyEPg/0mZ3sICmA/jS+Ltk9NPY6lYMCHPqiV3uyuJ iyBHWPYhs7k5Ryg9aUUEJoNNGJNAhAho5WKQUodQIyZjsC0qcw6i6JM9ad1wIAx7s4Ix nIKg== X-Gm-Message-State: ALoCoQktYuShgxQUZVYbCcM61qhZz3BcsEfkj/RIrPWp4nJ2VcC0IG4PeJulZm3IDtB16yoGo/iW X-Received: by 10.66.132.98 with SMTP id ot2mr4312610pab.31.1438668613077; Mon, 03 Aug 2015 23:10:13 -0700 (PDT) Received: from drinkcat.tpe.corp.google.com ([172.30.210.53]) by smtp.gmail.com with ESMTPSA id fv2sm9916456pbd.54.2015.08.03.23.10.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Aug 2015 23:10:12 -0700 (PDT) From: Nicolas Boichat To: Mark Brown Cc: Kukjin Kim , Krzysztof Kozlowski , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH 2/3] spi: ppc44x: Remove chipselect from setupxfer Date: Tue, 4 Aug 2015 14:09:57 +0800 Message-Id: <1438668598-6678-2-git-send-email-drinkcat@chromium.org> X-Mailer: git-send-email 2.5.0.rc2.392.g76e840b In-Reply-To: <1438668598-6678-1-git-send-email-drinkcat@chromium.org> References: <1438668598-6678-1-git-send-email-drinkcat@chromium.org> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The chipselect operation is already done in spi_bitbang_transfer_one, or in spi_bitbang_setup, so there is no need to do it in setupxfer as well. Signed-off-by: Nicolas Boichat --- drivers/spi/spi-ppc4xx.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c index 54fb984..55947f6 100644 --- a/drivers/spi/spi-ppc4xx.c +++ b/drivers/spi/spi-ppc4xx.c @@ -210,13 +210,6 @@ static int spi_ppc4xx_setupxfer(struct spi_device *spi, struct spi_transfer *t) if (in_8(&hw->regs->cdm) != cdm) out_8(&hw->regs->cdm, cdm); - spin_lock(&hw->bitbang.lock); - if (!hw->bitbang.busy) { - hw->bitbang.chipselect(spi, BITBANG_CS_INACTIVE); - /* Need to ndelay here? */ - } - spin_unlock(&hw->bitbang.lock); - return 0; }