| Message ID | 1446722128-11961-3-git-send-email-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote: > ARCH_SUNXI selects RESET_CONTROLLER. > The dependency "depends on RESET_CONTROLLER" is already met. No, it isn't. > config SPI_SUN6I > tristate "Allwinner A31 SPI controller" > depends on ARCH_SUNXI || COMPILE_TEST > - depends on RESET_CONTROLLER The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as ARCH_SUNXI.
2015-11-05 20:28 GMT+09:00 Mark Brown <broonie@kernel.org>: > On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote: >> ARCH_SUNXI selects RESET_CONTROLLER. >> The dependency "depends on RESET_CONTROLLER" is already met. > > No, it isn't. > >> config SPI_SUN6I >> tristate "Allwinner A31 SPI controller" >> depends on ARCH_SUNXI || COMPILE_TEST >> - depends on RESET_CONTROLLER > > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as > ARCH_SUNXI. The compile test of this driver should pass even if RESET_CONTROLLER is not defined. So, it does not matter for COMPILE_TEST.
On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote: > 2015-11-05 20:28 GMT+09:00 Mark Brown <broonie@kernel.org>: > > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as > > ARCH_SUNXI. > The compile test of this driver should pass even if RESET_CONTROLLER > is not defined. > So, it does not matter for COMPILE_TEST. If that is the case then the change here is that the dependency on RESET_CONTROLLER is just redundant which isn't what the commit message says.
2015-11-05 21:20 GMT+09:00 Mark Brown <broonie@kernel.org>: > On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote: >> 2015-11-05 20:28 GMT+09:00 Mark Brown <broonie@kernel.org>: > >> > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as >> > ARCH_SUNXI. > >> The compile test of this driver should pass even if RESET_CONTROLLER >> is not defined. >> So, it does not matter for COMPILE_TEST. > > If that is the case then the change here is that the dependency on > RESET_CONTROLLER is just redundant which isn't what the commit message > says. For compile test, right, "depends on RESET_CONTROLLER" is redundant in the first place. For run-time on real SoCs,the driver failed at the following point without the reset-controller sub-system. sspi->rstc = devm_reset_control_get(&pdev->dev, NULL); if (IS_ERR(sspi->rstc)) { dev_err(&pdev->dev, "Couldn't get reset controller\n"); ret = PTR_ERR(sspi->rstc); goto err_free_master; }
On Thu, Nov 05, 2015 at 09:32:15PM +0900, Masahiro Yamada wrote: > For compile test, right, "depends on RESET_CONTROLLER" is > redundant in the first place. > For run-time on real SoCs,the driver failed at the following point > without the reset-controller sub-system. Your changelog needs to say this clearly, right now what it's saying clearly doesn't correspond to what the change does.
2015-11-06 0:05 GMT+09:00 Mark Brown <broonie@kernel.org>: > On Thu, Nov 05, 2015 at 09:32:15PM +0900, Masahiro Yamada wrote: > >> For compile test, right, "depends on RESET_CONTROLLER" is >> redundant in the first place. > >> For run-time on real SoCs,the driver failed at the following point >> without the reset-controller sub-system. > > Your changelog needs to say this clearly, right now what it's saying > clearly doesn't correspond to what the change does. OK. This series is RFC and my main focus in on the 1/7. I will wait for more comments against the first one.
On Fri, Nov 06, 2015 at 03:00:04PM +0900, Masahiro Yamada wrote: > 2015-11-06 0:05 GMT+09:00 Mark Brown <broonie@kernel.org>: > > Your changelog needs to say this clearly, right now what it's saying > > clearly doesn't correspond to what the change does. > OK. > This series is RFC and my main focus in on the 1/7. > I will wait for more comments against the first one. You didn't send that patch to most of the recipients so I've no idea what that is...
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 4887f31..604ffab 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -536,7 +536,6 @@ config SPI_SUN4I config SPI_SUN6I tristate "Allwinner A31 SPI controller" depends on ARCH_SUNXI || COMPILE_TEST - depends on RESET_CONTROLLER help This enables using the SPI controller on the Allwinner A31 SoCs.
ARCH_SUNXI selects RESET_CONTROLLER. The dependency "depends on RESET_CONTROLLER" is already met. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/spi/Kconfig | 1 - 1 file changed, 1 deletion(-)