| Message ID | 1446722128-11961-4-git-send-email-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Nov 05, 2015 at 08:15:24PM +0900, Masahiro Yamada wrote: > ARCH_TEGRA selects RESET_CONTROLLER. > The dependency "depends on RESET_CONTROLLER" is already met. > tristate "NVIDIA Tegra114 SPI Controller" > depends on (ARCH_TEGRA && TEGRA20_APB_DMA) || COMPILE_TEST > - depends on RESET_CONTROLLER && HAS_DMA > + depends on HAS_DMA Again, this driver doesn't depend on ARCH_TEGRA.
2015-11-05 20:50 GMT+09:00 Mark Brown <broonie@kernel.org>: > On Thu, Nov 05, 2015 at 08:15:24PM +0900, Masahiro Yamada wrote: >> ARCH_TEGRA selects RESET_CONTROLLER. >> The dependency "depends on RESET_CONTROLLER" is already met. > >> tristate "NVIDIA Tegra114 SPI Controller" >> depends on (ARCH_TEGRA && TEGRA20_APB_DMA) || COMPILE_TEST >> - depends on RESET_CONTROLLER && HAS_DMA >> + depends on HAS_DMA > > Again, this driver doesn't depend on ARCH_TEGRA. How come? Sorry, I have not been tracking this sub-system, so I do not get the "Again". The prompt says "NVIDIA Tegra114 SPI Controller". It sounds natural for me that this driver depends on ARCH_TEGRA. No?
On Fri, Nov 06, 2015 at 03:02:57PM +0900, Masahiro Yamada wrote: > 2015-11-05 20:50 GMT+09:00 Mark Brown <broonie@kernel.org>: > > On Thu, Nov 05, 2015 at 08:15:24PM +0900, Masahiro Yamada wrote: > >> ARCH_TEGRA selects RESET_CONTROLLER. > >> The dependency "depends on RESET_CONTROLLER" is already met. > >> tristate "NVIDIA Tegra114 SPI Controller" > >> depends on (ARCH_TEGRA && TEGRA20_APB_DMA) || COMPILE_TEST > >> - depends on RESET_CONTROLLER && HAS_DMA > >> + depends on HAS_DMA > > Again, this driver doesn't depend on ARCH_TEGRA. > How come? > Sorry, I have not been tracking this sub-system, > so I do not get the "Again". It's the same issue as your previous patch - there's an || COMPILE_TEST in there.
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 604ffab..d853306 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -549,7 +549,7 @@ config SPI_MXS config SPI_TEGRA114 tristate "NVIDIA Tegra114 SPI Controller" depends on (ARCH_TEGRA && TEGRA20_APB_DMA) || COMPILE_TEST - depends on RESET_CONTROLLER && HAS_DMA + depends on HAS_DMA help SPI driver for NVIDIA Tegra114 SPI Controller interface. This controller is different than the older SoCs SPI controller and also register interface @@ -558,7 +558,6 @@ config SPI_TEGRA114 config SPI_TEGRA20_SFLASH tristate "Nvidia Tegra20 Serial flash Controller" depends on ARCH_TEGRA || COMPILE_TEST - depends on RESET_CONTROLLER help SPI driver for Nvidia Tegra20 Serial flash Controller interface. The main usecase of this controller is to use spi flash as boot @@ -567,7 +566,7 @@ config SPI_TEGRA20_SFLASH config SPI_TEGRA20_SLINK tristate "Nvidia Tegra20/Tegra30 SLINK Controller" depends on (ARCH_TEGRA && TEGRA20_APB_DMA) || COMPILE_TEST - depends on RESET_CONTROLLER && HAS_DMA + depends on HAS_DMA help SPI driver for Nvidia Tegra20/Tegra30 SLINK Controller interface.
ARCH_TEGRA selects RESET_CONTROLLER. The dependency "depends on RESET_CONTROLLER" is already met. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/spi/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)