diff mbox

[v2,1/8] spi: lm70llp: remove multiple blank lines

Message ID 1449485255-1103-1-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sudip Mukherjee Dec. 7, 2015, 10:47 a.m. UTC
checkpatch complains about multiple blank lines.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/spi/spi-lm70llp.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Mark Brown Dec. 7, 2015, 8:07 p.m. UTC | #1
On Mon, Dec 07, 2015 at 04:17:28PM +0530, Sudip Mukherjee wrote:
> checkpatch complains about multiple blank lines.

Please don't resubmit already applied patches, please submit against the
latest development code for the subsystem you're submitting to (unless
the change is a bug fix that should go to Linus).
Sudip Mukherjee Dec. 8, 2015, 4:33 a.m. UTC | #2
On Mon, Dec 07, 2015 at 08:07:37PM +0000, Mark Brown wrote:
> On Mon, Dec 07, 2015 at 04:17:28PM +0530, Sudip Mukherjee wrote:
> > checkpatch complains about multiple blank lines.
> 
> Please don't resubmit already applied patches, please submit against the
> latest development code for the subsystem you're submitting to (unless
> the change is a bug fix that should go to Linus).

I think there is some confusion. I am not seeing v1 of these patches in
for-next branch of your spi tree. And in review of v1 you said to use
dev_*. And for that last 2 patch of v1 changed and one extra came so I
sent the whole series as v2.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown Dec. 8, 2015, 12:49 p.m. UTC | #3
On Tue, Dec 08, 2015 at 10:03:00AM +0530, Sudip Mukherjee wrote:

> I think there is some confusion. I am not seeing v1 of these patches in
> for-next branch of your spi tree. And in review of v1 you said to use
> dev_*. And for that last 2 patch of v1 changed and one extra came so I
> sent the whole series as v2.

I'm not sure why you're not seeing them but they're there...
Sudip Mukherjee Dec. 8, 2015, 2:30 p.m. UTC | #4
On Tue, Dec 08, 2015 at 12:49:56PM +0000, Mark Brown wrote:
> On Tue, Dec 08, 2015 at 10:03:00AM +0530, Sudip Mukherjee wrote:
> 
> > I think there is some confusion. I am not seeing v1 of these patches in
> > for-next branch of your spi tree. And in review of v1 you said to use
> > dev_*. And for that last 2 patch of v1 changed and one extra came so I
> > sent the whole series as v2.
> 
> I'm not sure why you're not seeing them but they're there...

oops... no. Sorry for that. I think I checked before updating your tree
in my local tree.

sorry again.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index ba72347..eb4b421 100644
--- a/drivers/spi/spi-lm70llp.c
+++ b/drivers/spi/spi-lm70llp.c
@@ -23,11 +23,9 @@ 
 #include <linux/sysfs.h>
 #include <linux/workqueue.h>
 
-
 #include <linux/spi/spi.h>
 #include <linux/spi/spi_bitbang.h>
 
-
 /*
  * The LM70 communicates with a host processor using a 3-wire variant of
  * the SPI/Microwire bus interface. This driver specifically supports an
@@ -88,7 +86,6 @@  struct spi_lm70llp {
 /* REVISIT : ugly global ; provides "exclusive open" facility */
 static struct spi_lm70llp *lm70llp;
 
-
 /*-------------------------------------------------------------------*/
 
 static inline struct spi_lm70llp *spidev_to_pp(struct spi_device *spi)
@@ -319,7 +316,6 @@  static void spi_lm70llp_detach(struct parport *p)
 	lm70llp = NULL;
 }
 
-
 static struct parport_driver spi_lm70llp_drv = {
 	.name =		DRVNAME,
 	.attach =	spi_lm70llp_attach,