From patchwork Fri Dec 18 12:44:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Sperl X-Patchwork-Id: 7883291 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 42BE69F32E for ; Fri, 18 Dec 2015 12:44:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 72A9820384 for ; Fri, 18 Dec 2015 12:44:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE5AC201ED for ; Fri, 18 Dec 2015 12:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753502AbbLRMon (ORCPT ); Fri, 18 Dec 2015 07:44:43 -0500 Received: from 212-186-180-163.dynamic.surfer.at ([212.186.180.163]:39912 "EHLO cgate.sperl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbLRMom (ORCPT ); Fri, 18 Dec 2015 07:44:42 -0500 Received: from raspcm.intern.sperl.org (account martin@sperl.org [10.10.10.41] verified) by sperl.org (CommuniGate Pro SMTP 6.1.2) with ESMTPSA id 6390195; Fri, 18 Dec 2015 12:44:34 +0000 From: kernel@martin.sperl.org To: Geert Uytterhoeven , Mark Brown , linux-spi@vger.kernel.org Cc: Martin Sperl Subject: [PATCH 4/4] spi: loopback-test: added support for HW-loopback mode Date: Fri, 18 Dec 2015 12:44:27 +0000 Message-Id: <1450442668-2391-5-git-send-email-kernel@martin.sperl.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1450442668-2391-1-git-send-email-kernel@martin.sperl.org> References: <1450442668-2391-1-git-send-email-kernel@martin.sperl.org> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Martin Sperl If the module parameter "loopback" for testing RX to match TX is not set and the spi_master supports SPI_LOOP then SPI_LOOP as well as RX-data testing will get enabled. When the "loopback" module parameter is set then the SPI_LOOP support in spi_master will not get enabled, which means that MOSI needs to get connected to MISO by some other means (possibly via a jumper connection or a SN74AHCT125) Suggested-by: Geert Uytterhoeven Signed-off-by: Martin Sperl --- drivers/spi/spi-loopback-test.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) Note: this has been tested by faking SPI_LOOP support inside spi-bcm2835 (master->mode_bits |= SPI_LOOP;) and retaining the external link between MOSI and MISO. -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c index 6e76c3e..15207a7 100644 --- a/drivers/spi/spi-loopback-test.c +++ b/drivers/spi/spi-loopback-test.c @@ -289,7 +289,21 @@ static int spi_loopback_test_probe(struct spi_device *spi) { int ret; - dev_info(&spi->dev, "Executing spi-loopback-tests\n"); + /* enable HW-loopback automatically if the master supports it + * and we have the loopback module parameter unset + */ + if ((!loopback) && (spi->master->mode_bits & SPI_LOOP)) { + spi->mode |= SPI_LOOP; + ret = spi_setup(spi); + if (ret) + dev_err(&spi->dev, + "spi_setup failed to enable loopback: %i\n", + ret); + loopback = 1; + } + + dev_info(&spi->dev, "Executing spi-loopback-tests%s\n", + loopback ? " with loopback tests enabled" : ""); ret = spi_test_run_tests(spi, spi_tests);