From patchwork Tue Dec 22 18:03:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Sperl X-Patchwork-Id: 7906241 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 538ACBEEE5 for ; Tue, 22 Dec 2015 18:03:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7C4F420561 for ; Tue, 22 Dec 2015 18:03:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8680F2054A for ; Tue, 22 Dec 2015 18:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933255AbbLVSDr (ORCPT ); Tue, 22 Dec 2015 13:03:47 -0500 Received: from 212-186-180-163.dynamic.surfer.at ([212.186.180.163]:40208 "EHLO cgate.sperl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752764AbbLVSDp (ORCPT ); Tue, 22 Dec 2015 13:03:45 -0500 Received: from raspcm.intern.sperl.org (account martin@sperl.org [10.10.10.41] verified) by sperl.org (CommuniGate Pro SMTP 6.1.2) with ESMTPSA id 6390442; Tue, 22 Dec 2015 18:03:35 +0000 From: kernel@martin.sperl.org To: Mark Brown , linux-spi@vger.kernel.org Cc: Martin Sperl Subject: [PATCH v3 8/8] spi: loopback-test: added support for HW-loopback mode Date: Tue, 22 Dec 2015 18:03:28 +0000 Message-Id: <1450807408-2422-9-git-send-email-kernel@martin.sperl.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1450807408-2422-1-git-send-email-kernel@martin.sperl.org> References: <1450807408-2422-1-git-send-email-kernel@martin.sperl.org> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Martin Sperl If the module parameter "loopback" for testing RX to match TX is not set and the spi_master supports SPI_LOOP then SPI_LOOP as well as RX-data testing will get enabled. When the "loopback" module parameter is set then the SPI_LOOP support in spi_master will not get enabled, which means that MOSI needs to get connected to MISO by some other means (possibly via a simple jumper connection or a SN74AHCT125 connecting MOSI/MISO) Suggested-by: Geert Uytterhoeven Signed-off-by: Martin Sperl --- drivers/spi/spi-loopback-test.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c index 001f463..b49065a 100644 --- a/drivers/spi/spi-loopback-test.c +++ b/drivers/spi/spi-loopback-test.c @@ -288,8 +288,34 @@ static struct spi_test spi_tests[] = { static int spi_loopback_test_probe(struct spi_device *spi) { int ret; + char *msg; - dev_info(&spi->dev, "Executing spi-loopback-tests\n"); + /* + * Enable HW-loopback automatically if the master supports it + * and we have the have_rx_buf unset (set means that we have + * got an external loopback enabled, so no need to use SPI_LOOP) + */ + if (!check_rx_buf && (spi->master->mode_bits & SPI_LOOP)) { + spi->mode |= SPI_LOOP; + ret = spi_setup(spi); + if (ret) { + dev_err(&spi->dev, + "spi_setup failed to enable loopback: %i\n", + ret); + return ret; + } + + /* force checking rx_buf for valid (loopback) data */ + check_rx_buf = 1; + + msg = "with SPI_LOOP support"; + } else { + msg = (check_rx_buf) ? + "with external loopback" : + "without any loopback - rx_buf content is not checked"; + } + + dev_info(&spi->dev, "Executing spi-loopback-tests %s\n", msg); ret = spi_test_run_tests(spi, spi_tests);