From patchwork Fri Jan 22 11:06:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 8088991 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id ED8E59F6FA for ; Fri, 22 Jan 2016 11:08:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1B3CE203A1 for ; Fri, 22 Jan 2016 11:08:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27C2E2039E for ; Fri, 22 Jan 2016 11:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbcAVLIc (ORCPT ); Fri, 22 Jan 2016 06:08:32 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:34392 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375AbcAVLIV (ORCPT ); Fri, 22 Jan 2016 06:08:21 -0500 Received: by mail-pa0-f66.google.com with SMTP id yy13so3028790pab.1; Fri, 22 Jan 2016 03:08:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kpAl+MxiHyQhwUijb2ZqbPmCpd3iuXf+rjwhWYLzuYM=; b=k93dAMea8FWkhFywiU72/o3GN2QTHaQcdsB4xadVDoizdAtAgqGvVyj54HYhhj/r7E mz25q/06P0tiiweXQdAETmp5+LdMXfb+nMHTmW0gJR1tJxYFaw3kz+voZ7j9rS+tiNr0 GeTR8jmKiwbvH/kcX22mMrRtrxHzcFeC0RGjsjfNE8IESJOhfNMngQq4kppa6cIsqCFW sa+8TRUTgz5MhCeBLmtQqurbDazEsXO6Vw5PgXAh11bVwVyKqWQ3b1b6ySYfkSfnFFOM rrRCrY3MOjdiYIPSobL21C8QBWTTTzJmjI4Ju1H1CHhgrWK67EzUzfsZOKSJRXLJVYwE nVlg== X-Gm-Message-State: AG10YORh0G4wRDlvA5V1sueOOzR1rVr/sJzi0cKgSMfaaksETrSWSuKJGo0iaJpghVVhvg== X-Received: by 10.66.120.200 with SMTP id le8mr3431578pab.61.1453460899644; Fri, 22 Jan 2016 03:08:19 -0800 (PST) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id v2sm8931895pfi.93.2016.01.22.03.08.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Jan 2016 03:08:18 -0800 (PST) From: Caesar Wang To: Heiko Stuebner , Vinod Koul Cc: Sonny Rao , shawn.lin@rock-chips.com, dianders@chromium.org, linux-rockchip@lists.infradead.org, Addy Ke , Olof Johansson , Caesar Wang , Mark Brown , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 9/9] spi: rockchip: modify DMA max burst to 1 Date: Fri, 22 Jan 2016 19:06:52 +0800 Message-Id: <1453460812-8498-10-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1453460812-8498-1-git-send-email-wxt@rock-chips.com> References: <1453460812-8498-1-git-send-email-wxt@rock-chips.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Addy Ke Generic dma controller on Rockchips' platform cannot support DMAFLUSHP instruction which make dma to flush the req of non-aligned or non-multiple of what we need. That will cause an unrecoverable dma bus error. The saftest way is to set dma max burst to 1. Signed-off-by: Addy ke Fixes: 64e36824b32b06 ("spi/rockchip: add driver for Rockchip...") Signed-off-by: Shawn Lin cc: Heiko Stuebner cc: Olof Johansson cc: Doug Anderson cc: Sonny Rao Acked-by: Mark Brown Signed-off-by: Caesar Wang --- Changes in v7: None Changes in v6: - remove quirks and get dma caps in order to limit burst Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None Changes in v1: None drivers/spi/spi-rockchip.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 79a8bc4..aa9561f 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -199,6 +199,7 @@ struct rockchip_spi { struct sg_table rx_sg; struct rockchip_spi_dma_data dma_rx; struct rockchip_spi_dma_data dma_tx; + struct dma_slave_caps dma_caps; }; static inline void spi_enable_chip(struct rockchip_spi *rs, int enable) @@ -449,7 +450,10 @@ static void rockchip_spi_prepare_dma(struct rockchip_spi *rs) rxconf.direction = rs->dma_rx.direction; rxconf.src_addr = rs->dma_rx.addr; rxconf.src_addr_width = rs->n_bytes; - rxconf.src_maxburst = rs->n_bytes; + if (rs->dma_caps.max_burst > 4) + rxconf.src_maxburst = 4; + else + rxconf.src_maxburst = 1; dmaengine_slave_config(rs->dma_rx.ch, &rxconf); rxdesc = dmaengine_prep_slave_sg( @@ -466,7 +470,10 @@ static void rockchip_spi_prepare_dma(struct rockchip_spi *rs) txconf.direction = rs->dma_tx.direction; txconf.dst_addr = rs->dma_tx.addr; txconf.dst_addr_width = rs->n_bytes; - txconf.dst_maxburst = rs->n_bytes; + if (rs->dma_caps.max_burst > 4) + txconf.dst_maxburst = 4; + else + txconf.dst_maxburst = 1; dmaengine_slave_config(rs->dma_tx.ch, &txconf); txdesc = dmaengine_prep_slave_sg( @@ -730,6 +737,7 @@ static int rockchip_spi_probe(struct platform_device *pdev) } if (rs->dma_tx.ch && rs->dma_rx.ch) { + dma_get_slave_caps(rs->dma_rx.ch, &(rs->dma_caps)); rs->dma_tx.addr = (dma_addr_t)(mem->start + ROCKCHIP_SPI_TXDR); rs->dma_rx.addr = (dma_addr_t)(mem->start + ROCKCHIP_SPI_RXDR); rs->dma_tx.direction = DMA_MEM_TO_DEV;