From patchwork Wed Jun 22 13:42:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 9192999 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9DE7760756 for ; Wed, 22 Jun 2016 13:44:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CF7C283FD for ; Wed, 22 Jun 2016 13:44:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7BDC328406; Wed, 22 Jun 2016 13:44:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F138728406 for ; Wed, 22 Jun 2016 13:44:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbcFVNnh (ORCPT ); Wed, 22 Jun 2016 09:43:37 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:33861 "EHLO baptiste.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752678AbcFVNmS (ORCPT ); Wed, 22 Jun 2016 09:42:18 -0400 Received: from ayla.of.borg ([84.195.107.21]) by baptiste.telenet-ops.be with bizsmtp id 9piD1t00y0TjorY01piDcM; Wed, 22 Jun 2016 15:42:15 +0200 Received: from ramsan.of.borg ([192.168.97.29] helo=ramsan) by ayla.of.borg with esmtp (Exim 4.82) (envelope-from ) id 1bFiQ1-0005S6-JM; Wed, 22 Jun 2016 15:42:13 +0200 Received: from geert by ramsan with local (Exim 4.82) (envelope-from ) id 1bFiQ2-00016j-8s; Wed, 22 Jun 2016 15:42:14 +0200 From: Geert Uytterhoeven To: Mark Brown Cc: Rob Herring , Mark Rutland , Magnus Damm , Hisashi Nakamura , Hiromitsu Yamasaki , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH/RFC 6/6] spi: spidev: Allow direct references in DT from SPI slave controllers Date: Wed, 22 Jun 2016 15:42:09 +0200 Message-Id: <1466602929-4191-7-git-send-email-geert+renesas@glider.be> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1466602929-4191-1-git-send-email-geert+renesas@glider.be> References: <1466602929-4191-1-git-send-email-geert+renesas@glider.be> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP SPI slave protocols are typically handled in userspace through spidev, hence suppress the warning when the SPI controller is running in slave mode. Signed-off-by: Geert Uytterhoeven --- drivers/spi/spidev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index e3c19f30f591115a..8b590dd96480a9f9 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -713,7 +713,8 @@ static int spidev_probe(struct spi_device *spi) * compatible string, it is a Linux implementation thing * rather than a description of the hardware. */ - if (spi->dev.of_node && !of_match_device(spidev_dt_ids, &spi->dev)) { + if (spi->dev.of_node && !of_match_device(spidev_dt_ids, &spi->dev) && + !(spi->master->flags & SPI_MASTER_IS_SLAVE)) { dev_err(&spi->dev, "buggy DT: spidev listed directly in DT\n"); WARN_ON(spi->dev.of_node && !of_match_device(spidev_dt_ids, &spi->dev));