diff mbox

[v3,6/7] spi: s3c64xx: restore removed comments

Message ID 1468306444-18512-1-git-send-email-andi.shyti@samsung.com (mailing list archive)
State Accepted
Commit 0dbe70a1feb411d17fbcf8e73d61e6c7f33fda72
Headers show

Commit Message

Andi Shyti July 12, 2016, 6:54 a.m. UTC
Patch a9e93e8 has erroneously removed some comments which are
important to understand why the bus frequency is multiplied by
two during the spi transfer.

Reword the previous comment to a more appropriate message.

Suggested-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Reviewed-by: Michael Turquette <mturquette@baylibre.com>
---
Hi,

despite Mike's comments I'm sending the patch as it was
originally meant. I think that fixing the exact clk where to set
the rate should anyway go in a different patch.

V2->V3
The comment has been reworded as Sylwester recommended.

Thanks,
Andi

 drivers/spi/spi-s3c64xx.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown July 12, 2016, 8:22 a.m. UTC | #1
On Tue, Jul 12, 2016 at 03:54:04PM +0900, Andi Shyti wrote:
> Patch a9e93e8 has erroneously removed some comments which are
> important to understand why the bus frequency is multiplied by
> two during the spi transfer.

Please don't bury patches in the middle of old threads, it makes it very
confusing trying to figure out what's going on especially when you do
this one patch at a time in a series.  Submit new patches as a complete
series, ideally not threaded in with anything else (at least for me).
Andi Shyti July 12, 2016, 8:25 a.m. UTC | #2
> > Patch a9e93e8 has erroneously removed some comments which are
> > important to understand why the bus frequency is multiplied by
> > two during the spi transfer.
> 
> Please don't bury patches in the middle of old threads, it makes it very
> confusing trying to figure out what's going on especially when you do
> this one patch at a time in a series.  Submit new patches as a complete
> series, ideally not threaded in with anything else (at least for me).

OK, sorry, do you want me to send everything again?

Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown July 12, 2016, 9 a.m. UTC | #3
On Tue, Jul 12, 2016 at 05:25:46PM +0900, Andi Shyti wrote:

> > Please don't bury patches in the middle of old threads, it makes it very
> > confusing trying to figure out what's going on especially when you do
> > this one patch at a time in a series.  Submit new patches as a complete
> > series, ideally not threaded in with anything else (at least for me).

> OK, sorry, do you want me to send everything again?

Yes, please.
Michael Turquette July 12, 2016, 6:07 p.m. UTC | #4
Quoting Andi Shyti (2016-07-11 23:54:04)
> Patch a9e93e8 has erroneously removed some comments which are
> important to understand why the bus frequency is multiplied by
> two during the spi transfer.
> 
> Reword the previous comment to a more appropriate message.
> 
> Suggested-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> Reviewed-by: Michael Turquette <mturquette@baylibre.com>
> ---
> Hi,
> 
> despite Mike's comments I'm sending the patch as it was
> originally meant. I think that fixing the exact clk where to set
> the rate should anyway go in a different patch.

That sounds fair.

Regards,
Mike

> 
> V2->V3
> The comment has been reworded as Sylwester recommended.
> 
> Thanks,
> Andi
> 
>  drivers/spi/spi-s3c64xx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 6da663f..5bedafc 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -639,6 +639,7 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
>         writel(val, regs + S3C64XX_SPI_MODE_CFG);
>  
>         if (sdd->port_conf->clk_from_cmu) {
> +               /* The src_clk clock is divided internally by 2 */
>                 clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
>         } else {
>                 /* Configure Clock */
> -- 
> 2.8.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 6da663f..5bedafc 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -639,6 +639,7 @@  static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd)
 	writel(val, regs + S3C64XX_SPI_MODE_CFG);
 
 	if (sdd->port_conf->clk_from_cmu) {
+		/* The src_clk clock is divided internally by 2 */
 		clk_set_rate(sdd->src_clk, sdd->cur_speed * 2);
 	} else {
 		/* Configure Clock */