diff mbox

[2/2] spi: xilinx: Return IRQ_NONE if no interrupts were detected

Message ID 1468329881-5894-2-git-send-email-lars@metafoo.de (mailing list archive)
State Accepted
Commit d33648478501407267557b1bf6897169625f4178
Headers show

Commit Message

Lars-Peter Clausen July 12, 2016, 1:24 p.m. UTC
Return IRQ_NONE from the interrupt handler if the handler is running, but
no interrupt was detected. This allows the system to recover in case of an
interrupt storm due to an invalid interrupt configuration or faulty
hardware.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/spi/spi-xilinx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ricardo Ribalda Delgado July 12, 2016, 1:31 p.m. UTC | #1
Acked-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

On Tue, Jul 12, 2016 at 3:24 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> Return IRQ_NONE from the interrupt handler if the handler is running, but
> no interrupt was detected. This allows the system to recover in case of an
> interrupt storm due to an invalid interrupt configuration or faulty
> hardware.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>  drivers/spi/spi-xilinx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 334f423..f8280f3 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -341,9 +341,10 @@ static irqreturn_t xilinx_spi_irq(int irq, void *dev_id)
>
>         if (ipif_isr & XSPI_INTR_TX_EMPTY) {    /* Transmission completed */
>                 complete(&xspi->done);
> +               return IRQ_HANDLED;
>         }
>
> -       return IRQ_HANDLED;
> +       return IRQ_NONE;
>  }
>
>  static int xilinx_spi_find_buffer_size(struct xilinx_spi *xspi)
> --
> 2.1.4
>
diff mbox

Patch

diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
index 334f423..f8280f3 100644
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -341,9 +341,10 @@  static irqreturn_t xilinx_spi_irq(int irq, void *dev_id)
 
 	if (ipif_isr & XSPI_INTR_TX_EMPTY) {	/* Transmission completed */
 		complete(&xspi->done);
+		return IRQ_HANDLED;
 	}
 
-	return IRQ_HANDLED;
+	return IRQ_NONE;
 }
 
 static int xilinx_spi_find_buffer_size(struct xilinx_spi *xspi)