From patchwork Sun Sep 18 18:33:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 9338071 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DA5BC6022E for ; Sun, 18 Sep 2016 18:33:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C513927DF9 for ; Sun, 18 Sep 2016 18:33:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B7E2028C40; Sun, 18 Sep 2016 18:33:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0AA2827DF9 for ; Sun, 18 Sep 2016 18:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551AbcIRSdr (ORCPT ); Sun, 18 Sep 2016 14:33:47 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35002 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754189AbcIRSdq (ORCPT ); Sun, 18 Sep 2016 14:33:46 -0400 Received: by mail-wm0-f65.google.com with SMTP id 133so11635206wmq.2; Sun, 18 Sep 2016 11:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=ZHnl8hFxSPQpp7eFPFqZfoMgUP5xG2ztym4Yfkcoqp4=; b=V2yf6ToFW2r43CSB3NrCLmfFOkp+RPkQIMdcuMuGuVvG35YAcDQdOwspy/EpsoTQD4 9iHVEXB0GWm7W6MYKIk/1oLV6AJbvw3TzDlpg7+p3Vs/DBBWDFjb2+QPHcoFHs6e8i2s dgtxE02BwQOm0BrUJEcHdFRGHUW3hoYhUY9UK19C1Gbip/881UK1KZ3gIuNU3+HFqrwK wkrJBptVUE0VqJW3pJUtC4wBns/3Obp230IP+l2jxLHdFP4NgZ0SnOO7nZ4s0Rt9x8n0 HAY8mYzagPkIrgQyuYBiRWJu5Jq1wi3yLWwsRrKr2fae6Llx6XS3ewynFXNMjiM/BAmE wI8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZHnl8hFxSPQpp7eFPFqZfoMgUP5xG2ztym4Yfkcoqp4=; b=F7136rJdU1ucSj8bTz3XnzhIUVosmc4bgku1pEM918htjf79rAYMLCqfZwTo7qksHu uhvHgdlY2FzuCXHRyWFOwJZJuEXx1nF6xrcV60jkVYvrpGKzckzAkEjQ6MUW+2PKJWQq MmvcBKsjd5RO2929/nWgD4KL61xMr7iAWCZZG1wB3/H8zvK8TZz4bUD7NjQTDBo6iL0I 57L/zsD/pLnpaABGOnmFwRv/K28uVBqFt9AA/aqYPJ1tEVvO01+eG9fV9THNfOYadOwg ujsDxslnqAZN0Nt0N2HsBSNTisnCwPKkrXIyVM2geIbNgr7SSk09qGID3zQQeK7olW1g iCOA== X-Gm-Message-State: AE9vXwOmA/XqfsLhprs1JSTENyzV+WYiuqat/SsjglEMvYYFGyoRqYjs7G/JtbNMM4HNCA== X-Received: by 10.194.21.200 with SMTP id x8mr21054343wje.129.1474223624756; Sun, 18 Sep 2016 11:33:44 -0700 (PDT) Received: from localhost.localdomain (host-78-144-152-245.as13285.net. [78.144.152.245]) by smtp.gmail.com with ESMTPSA id q142sm18023165wmd.4.2016.09.18.11.33.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Sep 2016 11:33:42 -0700 (PDT) From: Sudip Mukherjee To: Mark Brown Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] spi: bcm-qspi: fix build error Date: Sun, 18 Sep 2016 19:33:34 +0100 Message-Id: <1474223614-18406-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP While building m68k allmodconfig, the build was failing with the error: drivers/spi/spi-bcm-qspi.c:1300:13: error: 'bcm_qspi_suspend' undeclared here (not in a function) .suspend = bcm_qspi_suspend, drivers/spi/spi-bcm-qspi.c:1301:13: error: 'bcm_qspi_resume' undeclared here (not in a function) .resume = bcm_qspi_resume, bcm_qspi_suspend() and bcm_qspi_resume() are only defined when CONFIG_PM_SLEEP is defined. Use the macro SET_SYSTEM_SLEEP_PM_OPS to use it only when CONFIG_PM_SLEEP is defined. Signed-off-by: Sudip Mukherjee --- m68k build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/160355865 drivers/spi/spi-bcm-qspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c index 8fff43e..f06a3824 100644 --- a/drivers/spi/spi-bcm-qspi.c +++ b/drivers/spi/spi-bcm-qspi.c @@ -1297,8 +1297,8 @@ static int bcm_qspi_resume(struct device *dev) #endif /* CONFIG_PM_SLEEP */ const struct dev_pm_ops bcm_qspi_pm_ops = { - .suspend = bcm_qspi_suspend, - .resume = bcm_qspi_resume, + SET_SYSTEM_SLEEP_PM_OPS(bcm_qspi_suspend, + bcm_qspi_resume) }; /* pm_ops to be called by SoC specific platform driver */ EXPORT_SYMBOL_GPL(bcm_qspi_pm_ops);