diff mbox

[1/1] Add devices to spidev device tree compatibility list

Message ID 1475230554-5986-1-git-send-email-fabien.lahoudere@collabora.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Fabien Lahoudere Sept. 30, 2016, 10:15 a.m. UTC
Entries are needed in the spidev ID list to configure configure it from a
device tree. Add entries for the following devices:
- "fsl,mk20fn1m0vmd12" : a cortex m4 based chip
- "exar,xra1403" : a GPIO expander

Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
---
 drivers/spi/spidev.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Mark Brown Sept. 30, 2016, 4:08 p.m. UTC | #1
On Fri, Sep 30, 2016 at 12:15:54PM +0200, Fabien Lahoudere wrote:

> - "fsl,mk20fn1m0vmd12" : a cortex m4 based chip

> +	{ .compatible = "fsl,MK20FN1M0VMD12" },

This compatible is in uppercase which is not the normal style for DT
bindings at all.  I'd also guess that this is a binding for a specific
application running on this device rather than the chip itself.
Geert Uytterhoeven Sept. 30, 2016, 5:35 p.m. UTC | #2
On Fri, Sep 30, 2016 at 12:15 PM, Fabien Lahoudere
<fabien.lahoudere@collabora.co.uk> wrote:
> Entries are needed in the spidev ID list to configure configure it from a
> device tree. Add entries for the following devices:

> - "exar,xra1403" : a GPIO expander

Looks like a suitable target for a drivers/gpio/ driver.
Datasheet available at
https://www.exar.com/product/interface/bridges/bridging-solutions/spi-gpio-expanders/xra1403

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Fabien Lahoudere Oct. 6, 2016, 8:01 a.m. UTC | #3
Hi,

On 30/09/16 19:35, Geert Uytterhoeven wrote:
> On Fri, Sep 30, 2016 at 12:15 PM, Fabien Lahoudere
> <fabien.lahoudere@collabora.co.uk> wrote:
>> Entries are needed in the spidev ID list to configure configure it from a
>> device tree. Add entries for the following devices:
>
>> - "exar,xra1403" : a GPIO expander
>
> Looks like a suitable target for a drivers/gpio/ driver.
> Datasheet available at
> https://www.exar.com/product/interface/bridges/bridging-solutions/spi-gpio-expanders/xra1403
>

Good idea, however we have to measure impact of this change on the project.

Thanks

Fabien

> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 2e05046..821937a 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -696,6 +696,8 @@  static struct class *spidev_class;
 static const struct of_device_id spidev_dt_ids[] = {
 	{ .compatible = "rohm,dh2228fv" },
 	{ .compatible = "lineartechnology,ltc2488" },
+	{ .compatible = "fsl,MK20FN1M0VMD12" },
+	{ .compatible = "exar,xra1403" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, spidev_dt_ids);