From patchwork Fri Sep 30 14:23:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vikram N X-Patchwork-Id: 9358351 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6517F6077B for ; Fri, 30 Sep 2016 14:24:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53B452A027 for ; Fri, 30 Sep 2016 14:24:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 42EC02A061; Fri, 30 Sep 2016 14:24:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E01CD2A027 for ; Fri, 30 Sep 2016 14:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932741AbcI3OYr (ORCPT ); Fri, 30 Sep 2016 10:24:47 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34814 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932561AbcI3OYq (ORCPT ); Fri, 30 Sep 2016 10:24:46 -0400 Received: by mail-pf0-f193.google.com with SMTP id 21so5086470pfy.1; Fri, 30 Sep 2016 07:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=W+xnga1qV6oOnc+pWDEGai+VzJOgrNRpkHD1uzmHlEQ=; b=zhV7RUI6KxwOXNOV7pt9wwmr1gw/82Oy5U3Cx1iABW3ftI3ByHY5wo+OACbCUUyMUu +WatYTffnQEH2bNwF4qe0Hz9EMPpkXf1YsuYa+V88VbdwUO46lBZOd744QhWcqHK9rgY InSLVue814fWk8DhytZKtVAWsEUXLcEx3OZ6E6XbU3zXeJOFIbFMZ0yrkBpdUyMSNsmZ JfjFUtv+U32kggzg148cExKwAh3RQejs11wIwuY/jfR0GlyY9sXt1ZVs0wDlew5Wcnhl 6S1sxU7qgutM//i0yLgwY7gXtgiGYPSn3VdZoe0w9IssLki8+9gXRZXvGKwe6rQGtI7W s4Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=W+xnga1qV6oOnc+pWDEGai+VzJOgrNRpkHD1uzmHlEQ=; b=Bup2nrCi9ic7ReM05kxcHj3BFGuVwyCPGfRsb3+ZZmy3X8zaoB4XHkTK6htVJqx+hi 5CTAWLZWvi4DKsLPRu/17WIilPUIUexnVpLKPwDiYn0/xfKvasq4Sj+ypbpv7WsMAQsE AflP/uZu8ZDEHu65pYuDsmJyeEjG2HPPd60FZnsSbBJg6kqA6tdg4XaTXEXdZZ3kleXu F95+g7XtSdHqK04zxvGe1Qqrqr9lUwA8GGuyCemWNiS4x/h1WmxuS1KODsioW4tJ85co bynIcg+R0CnG6/4DLLKcFM7DNqd61EafrtbOCM9813ln/C1p0zKqim7KESKG0zGHRbqn aqcg== X-Gm-Message-State: AA6/9RlvWAJPjK7s8BeTOIFeQPXrM297U5E7IfT2tY4rDccNc4GgLy4xPsnYyZqD5nYzhA== X-Received: by 10.98.197.1 with SMTP id j1mr12478658pfg.77.1475245485531; Fri, 30 Sep 2016 07:24:45 -0700 (PDT) Received: from localhost.localdomain ([106.51.129.105]) by smtp.gmail.com with ESMTPSA id vo3sm13305845pab.26.2016.09.30.07.24.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Sep 2016 07:24:44 -0700 (PDT) From: Vikram N To: broonie@kernel.org Cc: Vikram N , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: omap2-mcspi: Fix modifying platform resource data Date: Fri, 30 Sep 2016 19:53:11 +0530 Message-Id: <1475245427-4140-1-git-send-email-vicky773@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP currently during probe the resource data gets modified and device physical address remains valid only during first load. If the module is unloaded and loaded again, the ioremp will be done on a incorrect address as the resource was modified during previous module load. This patch fixes this issue. Signed-off-by: Vikram N --- drivers/spi/spi-omap2-mcspi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index d5157b2..3567e1d 100644 --- a/drivers/spi/spi-omap2-mcspi.c +++ b/drivers/spi/spi-omap2-mcspi.c @@ -1391,15 +1391,13 @@ static int omap2_mcspi_probe(struct platform_device *pdev) goto free_master; } - r->start += regs_offset; - r->end += regs_offset; - mcspi->phys = r->start; - mcspi->base = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(mcspi->base)) { status = PTR_ERR(mcspi->base); goto free_master; } + mcspi->phys = r->start + regs_offset; + mcspi->base += regs_offset; mcspi->dev = &pdev->dev;