From patchwork Fri Mar 17 18:17:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 9631149 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7D559602D6 for ; Fri, 17 Mar 2017 18:18:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 78468284CB for ; Fri, 17 Mar 2017 18:18:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D0E428616; Fri, 17 Mar 2017 18:18:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41EF828533 for ; Fri, 17 Mar 2017 18:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751345AbdCQSSC (ORCPT ); Fri, 17 Mar 2017 14:18:02 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35569 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbdCQSSB (ORCPT ); Fri, 17 Mar 2017 14:18:01 -0400 Received: by mail-pf0-f195.google.com with SMTP id x63so9329445pfx.2 for ; Fri, 17 Mar 2017 11:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tuwD5ERvB9L4yNDs7ZwyUAmFeOT4tZsJMDYAMTbe/Lk=; b=oAuIUAlPRIzXTb4Autk50Q4E56ZSdBUKl/E0HmKpnxq1o46nDL4fayKT9mBvJzHUgc Hm+nwLScnt1/5yFmqMddT5LLw6WhOsNCyALFBtgfcDqnYzlmPH6i2GL3MGNVz3I70lwd SwD0ANvwNd9GD51hvlEQm+oT5/c/XtFsCYbvPJgyAuvPLus442nCIonPez0iAXxYvsiG BHFoLRsTIcdqjhq2RH62hYiB4Nk3nMqlenenB2rKQnGMLXDBt/4unLkHWaFKe/3MRO/z XveS4Dy4ypFY0TbrMOPYiqQv3HUMWFi/koNItNrfV80jwpPlbM5XzcFW8zU+yX7J6B65 Q2eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tuwD5ERvB9L4yNDs7ZwyUAmFeOT4tZsJMDYAMTbe/Lk=; b=BTUX1BPl//9c8EO5UApf3htiwV4XlsDhgPVaIa2hct0qzT0heg3ibcdKXbNki9Fed9 BLAsYtdhwwS/ZW3hPAUeiA5BPT6amWr98iNQc/oyqQluyXbLgvy76BCkakyZZUPSzfDp vgyePdXxCvg9V6bo4ohkH63nX+zMb7OwbXXH7ux7oLE3eoHzw7bMiCIIPyxd97xUd0ve MaiwaRyEzUxWJlpvbomv1nw05Z9gRjGqu7Uv7PDXbhHUSOZdAZhYqaU1w+W6fS7GifjM ZXRFYr7UjCu3Hx/OyI4GL5w0XteOktTuaqGAS7qfB+fm1qXE2pSA/E8o6HNbnW6/3C79 pXBA== X-Gm-Message-State: AFeK/H2Qc2qqFvkOPUzbdTO57vg3RTBVdxRPVXEqjLO8L9/YydEsyc3Fmy1tLen7taKLVQ== X-Received: by 10.99.170.5 with SMTP id e5mr17474385pgf.89.1489774680138; Fri, 17 Mar 2017 11:18:00 -0700 (PDT) Received: from mita-ThinkPad-T540p.local ([240f:4:c2bc:1:273e:de02:139f:cc26]) by smtp.gmail.com with ESMTPSA id 189sm7104355pgd.39.2017.03.17.11.17.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Mar 2017 11:17:59 -0700 (PDT) From: Akinobu Mita To: linux-spi@vger.kernel.org Cc: Akinobu Mita , Martin Sperl , Mark Brown Subject: [PATCH 1/6] spi: loopback-test: correct mismatched test description and configuration Date: Sat, 18 Mar 2017 03:17:26 +0900 Message-Id: <1489774651-30170-2-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1489774651-30170-1-git-send-email-akinobu.mita@gmail.com> References: <1489774651-30170-1-git-send-email-akinobu.mita@gmail.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The test "two tx-transfers - alter first" actually alters the second not the first transfer. Similarly the test "two tx-transfers - alter second" actually alters the first not the second transfer. The mismatches for the two symmetrical tests cancel each other's mistakes. But it's better to fix the mismatches to avoid confusion. Cc: Martin Sperl Cc: Mark Brown Signed-off-by: Akinobu Mita --- drivers/spi/spi-loopback-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c index 50e620f..99422f3 100644 --- a/drivers/spi/spi-loopback-test.c +++ b/drivers/spi/spi-loopback-test.c @@ -132,7 +132,7 @@ static struct spi_test spi_tests[] = { .fill_option = FILL_COUNT_8, .iterate_len = { ITERATE_MAX_LEN }, .iterate_tx_align = ITERATE_ALIGN, - .iterate_transfer_mask = BIT(1), + .iterate_transfer_mask = BIT(0), .transfers = { { .len = 1, @@ -149,7 +149,7 @@ static struct spi_test spi_tests[] = { .fill_option = FILL_COUNT_8, .iterate_len = { ITERATE_MAX_LEN }, .iterate_tx_align = ITERATE_ALIGN, - .iterate_transfer_mask = BIT(0), + .iterate_transfer_mask = BIT(1), .transfers = { { .len = 16,