From patchwork Tue Jun 27 09:45:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varadarajan Narayanan X-Patchwork-Id: 9811161 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5CBEA60351 for ; Tue, 27 Jun 2017 09:46:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4B1D228614 for ; Tue, 27 Jun 2017 09:46:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F7282861C; Tue, 27 Jun 2017 09:46:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E867528614 for ; Tue, 27 Jun 2017 09:46:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbdF0JqM (ORCPT ); Tue, 27 Jun 2017 05:46:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51540 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752715AbdF0JqH (ORCPT ); Tue, 27 Jun 2017 05:46:07 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 26A9D607CB; Tue, 27 Jun 2017 09:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1498556766; bh=oHWvkuXU/GlXuuwF652mPg6KVqk3RHqpiPXhy8WHnzY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JXAkBNItPSODzF60F9MKg5dbEwyF0m3Nb612oazWIewXIZiL8SguabC8LiF7B78of V1voFiRSEAm6v8/aw1uVRsL5w0fAvnKQKYSpoOfl6enqVvUZnuZ0Zl84tUbfKpfojv RZEIM2nm70o11o5aYYut6sM7oMzxmdxHnGUn1L+Y= Received: from varda-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: varada@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A96CC6074C; Tue, 27 Jun 2017 09:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1498556764; bh=oHWvkuXU/GlXuuwF652mPg6KVqk3RHqpiPXhy8WHnzY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=grU05YKuYEFmAVwzSuVHtbi9/JBPf1vagwH51/HNUC/5B7VRSs6zX7pTNJgqnNK1r nxHWQeCCK/793LsD1ux1kvzRhVtqCKL5e7CUjdMB3ZUFClCuXgGAQVJfjHv1ixUPgW f0nO042Sav0Ppk4f5wkOWpfeSdXO5lfOWqfhxFTU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A96CC6074C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=varada@codeaurora.org From: Varadarajan Narayanan To: broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org Cc: Varadarajan Narayanan Subject: [PATCH v4 06/14] spi: qup: Fix error handling in spi_qup_prep_sg Date: Tue, 27 Jun 2017 15:15:23 +0530 Message-Id: <1498556731-13087-7-git-send-email-varada@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1498556731-13087-1-git-send-email-varada@codeaurora.org> References: <1498556731-13087-1-git-send-email-varada@codeaurora.org> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 0683e47..e2b4a50 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -310,8 +310,8 @@ static int spi_qup_prep_sg(struct spi_master *master, struct spi_transfer *xfer, } desc = dmaengine_prep_slave_sg(chan, sgl, nents, dir, flags); - if (!desc) - return -EINVAL; + if (IS_ERR_OR_NULL(desc)) + return desc ? PTR_ERR(desc) : -EINVAL; desc->callback = callback; desc->callback_param = data;