| Message ID | 1544181199-3373-3-git-send-email-masonccyang@mxic.com.tw (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: Add Renesas R-Car Gen3 RPC SPI driver | expand |
Hello! On 12/07/2018 02:13 PM, Mason Yang wrote: > Document the bindings used by the Renesas R-Car Gen3 RPC controller. > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > --- > .../devicetree/bindings/spi/spi-renesas-rpc.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > > diff --git a/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > new file mode 100644 > index 0000000..a191f70 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > @@ -0,0 +1,38 @@ > +Renesas R-Car Gen3 RPC controller Device Tree Bindings > +------------------------------------------------------ > + > +Required properties: > +- compatible: should be "renesas,r8a77995-rpc" > +- #address-cells: should be 1 > +- #size-cells: should be 0 > +- reg: should contain 2 entries, one for the registers and one for the direct > + mapping area > +- reg-names: should contain "rpc_regs" and "dirmap" Please drop this "rpc_" thing, I think "regs" should be enough. > +- interrupts: interrupt line connected to the RPC controller > +- clock-names: should contain "clk_rpc" Please drop this "clk_" thing. BTW, what's with the RPCD2 clock? > +- clocks: should contain 1 entries for the module's clock > +- rpc-mode: should contain "rpc-spi-flash" for rpc spi mode or > + "rpc-hyperflash" for rpc hyerflash mode. I think the prop should be called "renesas,rpc-mode" and the values should be just "spi" and "hyperflash". [...] MBR, Sergei
On 12/07/2018 05:03 PM, Sergei Shtylyov wrote: > Hello! > > On 12/07/2018 02:13 PM, Mason Yang wrote: > >> Document the bindings used by the Renesas R-Car Gen3 RPC controller. >> >> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> >> --- >> .../devicetree/bindings/spi/spi-renesas-rpc.txt | 38 ++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> new file mode 100644 >> index 0000000..a191f70 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt >> @@ -0,0 +1,38 @@ >> +Renesas R-Car Gen3 RPC controller Device Tree Bindings >> +------------------------------------------------------ >> + >> +Required properties: >> +- compatible: should be "renesas,r8a77995-rpc" >> +- #address-cells: should be 1 >> +- #size-cells: should be 0 >> +- reg: should contain 2 entries, one for the registers and one for the direct >> + mapping area >> +- reg-names: should contain "rpc_regs" and "dirmap" > > Please drop this "rpc_" thing, I think "regs" should be enough. > >> +- interrupts: interrupt line connected to the RPC controller >> +- clock-names: should contain "clk_rpc" > > Please drop this "clk_" thing. BTW, what's with the RPCD2 clock? > >> +- clocks: should contain 1 entries for the module's clock >> +- rpc-mode: should contain "rpc-spi-flash" for rpc spi mode or >> + "rpc-hyperflash" for rpc hyerflash mode. > > I think the prop should be called "renesas,rpc-mode" and the values should be > just "spi" and "hyperflash". Like I said before, you can determine the mode from the subnode attached to the controller, we don't need special prop for that.
Hello! Should be "dt-bindings: " in the subject... MBR, Sergei
On 12/07/2018 02:13 PM, Mason Yang wrote: > Document the bindings used by the Renesas R-Car Gen3 RPC controller. > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > --- > .../devicetree/bindings/spi/spi-renesas-rpc.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > > diff --git a/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > new file mode 100644 > index 0000000..a191f70 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt > @@ -0,0 +1,38 @@ > +Renesas R-Car Gen3 RPC controller Device Tree Bindings > +------------------------------------------------------ > + > +Required properties: > +- compatible: should be "renesas,r8a77995-rpc" > +- #address-cells: should be 1 > +- #size-cells: should be 0 > +- reg: should contain 2 entries, one for the registers and one for the direct > + mapping area > +- reg-names: should contain "rpc_regs" and "dirmap" > +- interrupts: interrupt line connected to the RPC controller Required prop but it's missing in your example below... > +- clock-names: should contain "clk_rpc" > +- clocks: should contain 1 entries for the module's clock > +- rpc-mode: should contain "rpc-spi-flash" for rpc spi mode or > + "rpc-hyperflash" for rpc hyerflash mode. > + > +Example: > + > + rpc: rpc@ee200000 { > + compatible = "renesas,r8a77995-rpc"; > + reg = <0 0xee200000 0 0x8100>, <0 0x08000000 0 0x4000000>; > + reg-names = "rpc_regs", "dirmap"; > + clocks = <&cpg CPG_MOD 917>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 917>; > + clock-names = "clk_rpc"; > + rpc-mode = "rpc-spi-flash"; > + #address-cells = <1>; > + #size-cells = <0>; [...] MBR, Sergei
diff --git a/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt new file mode 100644 index 0000000..a191f70 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt @@ -0,0 +1,38 @@ +Renesas R-Car Gen3 RPC controller Device Tree Bindings +------------------------------------------------------ + +Required properties: +- compatible: should be "renesas,r8a77995-rpc" +- #address-cells: should be 1 +- #size-cells: should be 0 +- reg: should contain 2 entries, one for the registers and one for the direct + mapping area +- reg-names: should contain "rpc_regs" and "dirmap" +- interrupts: interrupt line connected to the RPC controller +- clock-names: should contain "clk_rpc" +- clocks: should contain 1 entries for the module's clock +- rpc-mode: should contain "rpc-spi-flash" for rpc spi mode or + "rpc-hyperflash" for rpc hyerflash mode. + +Example: + + rpc: rpc@ee200000 { + compatible = "renesas,r8a77995-rpc"; + reg = <0 0xee200000 0 0x8100>, <0 0x08000000 0 0x4000000>; + reg-names = "rpc_regs", "dirmap"; + clocks = <&cpg CPG_MOD 917>; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 917>; + clock-names = "clk_rpc"; + rpc-mode = "rpc-spi-flash"; + #address-cells = <1>; + #size-cells = <0>; + + flash@0 { + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <40000000>; + spi-tx-bus-width = <1>; + spi-rx-bus-width = <1>; + }; + };
Document the bindings used by the Renesas R-Car Gen3 RPC controller. Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> --- .../devicetree/bindings/spi/spi-renesas-rpc.txt | 38 ++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt