From patchwork Wed Oct 30 09:03:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: luhua xu X-Patchwork-Id: 11219307 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B3AAE1747 for ; Wed, 30 Oct 2019 09:03:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BD5D2083E for ; Wed, 30 Oct 2019 09:03:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbfJ3JD4 (ORCPT ); Wed, 30 Oct 2019 05:03:56 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:21613 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726177AbfJ3JD4 (ORCPT ); Wed, 30 Oct 2019 05:03:56 -0400 X-UUID: 5c5d35fef1344567b3c5a1e569a2523a-20191030 X-UUID: 5c5d35fef1344567b3c5a1e569a2523a-20191030 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 26910532; Wed, 30 Oct 2019 17:03:51 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 30 Oct 2019 17:03:47 +0800 Received: from localhost.localdomain (10.15.20.246) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 30 Oct 2019 17:03:47 +0800 From: Luhua Xu To: Mark Brown , Matthias Brugger CC: , , , , , Luhua Xu Subject: [PATCH V2] spi: add power control when set_cs Date: Wed, 30 Oct 2019 17:03:54 +0800 Message-ID: <1572426234-30019-1-git-send-email-luhua.xu@mediatek.com> X-Mailer: git-send-email 2.6.4 MIME-Version: 1.0 X-MTK: N Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org From: "Luhua Xu" As to set_cs takes effect immediately, power spi is needed when setup spi. Cc: Mark Brown Signed-off-by: Luhua Xu --- V2: - move set_cs PM control from .set_cs callback in vendor driver to spi_setup in spi framework. drivers/spi/spi.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index f9502db..19007e0 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -3091,7 +3091,20 @@ int spi_setup(struct spi_device *spi) if (spi->controller->setup) status = spi->controller->setup(spi); - spi_set_cs(spi, false); + if (spi->controller->auto_runtime_pm && spi->controller->set_cs) { + status = pm_runtime_get_sync(spi->controller->dev.parent); + if (status < 0) { + pm_runtime_put_noidle(spi->controller->dev.parent); + dev_err(&spi->controller->dev, "Failed to power device: %d\n", + status); + return status; + } + spi_set_cs(spi, false); + pm_runtime_mark_last_busy(spi->controller->dev.parent); + pm_runtime_put_autosuspend(spi->controller->dev.parent); + } else { + spi_set_cs(spi, false); + } if (spi->rt && !spi->controller->rt) { spi->controller->rt = true;