From patchwork Fri Oct 19 11:15:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Porter X-Patchwork-Id: 1618001 Return-Path: X-Original-To: patchwork-spi-devel-general@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) by patchwork2.kernel.org (Postfix) with ESMTP id D3A7BDF2AB for ; Fri, 19 Oct 2012 11:14:46 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-4.v29.ch3.sourceforge.com) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1TPAXO-0002fp-8m; Fri, 19 Oct 2012 11:14:46 +0000 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1TPAXM-0002fh-MP for spi-devel-general@lists.sourceforge.net; Fri, 19 Oct 2012 11:14:44 +0000 Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.210.175 as permitted sender) client-ip=209.85.210.175; envelope-from=ohiomdp@gmail.com; helo=mail-ia0-f175.google.com; Received: from mail-ia0-f175.google.com ([209.85.210.175]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1TPAXK-0003wy-F3 for spi-devel-general@lists.sourceforge.net; Fri, 19 Oct 2012 11:14:44 +0000 Received: by mail-ia0-f175.google.com with SMTP id b35so211582iac.34 for ; Fri, 19 Oct 2012 04:14:37 -0700 (PDT) Received: by 10.50.217.167 with SMTP id oz7mr7805668igc.3.1350645277000; Fri, 19 Oct 2012 04:14:37 -0700 (PDT) Received: from beef (cpe-24-166-64-7.neo.res.rr.com. [24.166.64.7]) by mx.google.com with ESMTPS id u4sm1166337igw.6.2012.10.19.04.14.34 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Oct 2012 04:14:35 -0700 (PDT) Date: Fri, 19 Oct 2012 07:15:58 -0400 From: Matt Porter To: "Bedia, Vaibhav" Subject: Re: [RFC PATCH v3 00/16] DMA Engine support for AM33XX Message-ID: <20121019111558.GD25164@beef> References: <1350566815-409-1-git-send-email-mporter@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ohiomdp[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 AWL AWL: From: address is in the auto white-list X-Headers-End: 1TPAXK-0003wy-F3 Cc: Linux DaVinci Kernel List , Linux OMAP List , Russell King , "Cousson, Benoit" , Arnd Bergmann , Linux Documentation List , Tony Lindgren , Linux MMC List , Devicetree Discuss , Mark Brown , "Nori, Sekhar" , Linux Kernel Mailing List , Rob Herring , Vinod Koul , Rob Landley , Dan Williams , Linux SPI Devel List , Chris Ball , Linux ARM Kernel List X-BeenThere: spi-devel-general@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux SPI core/device drivers discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces@lists.sourceforge.net On Fri, Oct 19, 2012 at 10:26:20AM +0000, Bedia, Vaibhav wrote: > Hi Matt, > > On Thu, Oct 18, 2012 at 18:56:39, Porter, Matt wrote: > > Changes since v2: > > - Rebased on 3.7-rc1 > > - Fixed bug in DT/pdata parsing first found by Gururaja > > that turned out to be masked by some toolchains > > - Dropped unused mach-omap2/devices.c hsmmc patch > > - Added AM33XX crossbar DMA event mux support > > - Added am335x-evm support > > > > Changes since v1: > > - Rebased on top of mainline from 12250d8 > > - Dropped the feature removal schedule patch > > - Implemented dma_request_slave_channel_compat() and > > converted the mmc and spi drivers to use it > > - Dropped unneeded #address-cells and #size-cells from > > EDMA DT support > > - Moved private EDMA header to linux/platform_data/ and > > removed some unneeded definitions > > - Fixed parsing of optional properties > > > > TODO: > > - Add dmaengine support for per-channel caps so the > > hack to set the maximum segments can be replaced with > > a query to the dmaengine driver > > > > This series adds DMA Engine support for AM33xx, which uses > > an EDMA DMAC. The EDMA DMAC has been previously supported by only > > a private API implementation (much like the situation with OMAP > > DMA) found on the DaVinci family of SoCs. > > > > The series applies on top of 3.7-rc1 and the following patches: > > > > - GPMC fails to reserve memory fix: > > http://www.spinics.net/lists/linux-omap/msg79675.html > > - TPS65910 regulator fix: > > https://patchwork.kernel.org/patch/1593651/ > > - dmaengine DT support from Vinod's dmaengine_dt branch in > > git://git.infradead.org/users/vkoul/slave-dma.git since > > 027478851791df751176398be02a3b1c5f6aa824 > > > > The approach taken is similar to how OMAP DMA is being converted to > > DMA Engine support. With the functional EDMA private API already > > existing in mach-davinci/dma.c, we first move that to an ARM common > > area so it can be shared. Adding DT and runtime PM support to the > > private EDMA API implementation allows it to run on AM33xx. AM33xx > > *only* boots using DT so we leverage Jon's generic DT DMA helpers to > > register EDMA DMAC with the of_dma framework and then add support > > for calling the dma_request_slave_channel() API to both the mmc > > and spi drivers. > > > > With this series both BeagleBone and the AM335x EVM have working > > MMC and SPI support. > > > > This is tested on BeagleBone with a SPI framebuffer driver and MMC > > rootfs. A trivial gpio DMA event misc driver was used to test the > > crossbar DMA event support. It is also tested on the AM335x EVM > > with the onboard SPI flash and MMC rootfs. The branch at > > https://github.com/ohporter/linux/tree/edma-dmaengine-v3 has the > > complete series, dependencies, and some test drivers/defconfigs. > > > > I didn't see all the patches that you posted on edma-dmaengine-v3 > but I do seem them on edma-dmaengine-am33xx-v3 branch. I see I referenced the wrong branch in the cover letter. Thanks for testing and noticing this. Sorry to make you hunt for the correct branch in that repo. ;) https://github.com/ohporter/linux/tree/edma-dmaengine-am33xx-v3 is indeed the correct branch for those wanting to pull this in or grab some of the not-to-be-merged drivers I used for testing. > I added a couple of patches to enable earlyprintk and build the DTB > appended kernel image uImage-dtb.am335x-evm > > Here's what i see > > [...] > [ 0.175354] edma: probe of 49000000.edma failed with error -16 I missed an uninitialized pdata case in the bug fixes mentioned in the changelog and the folks previously failing the same way didn't hit the case I suspect you are hitting. Can you try this and let me know how it works? Thanks, Matt ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index b761b7a..b43b327 100644 --- a/arch/arm/common/edma.c +++ b/arch/arm/common/edma.c @@ -1619,7 +1619,7 @@ static int __init edma_probe(struct platform_device *pdev) if (node) { pdata = devm_kzalloc(dev, - sizeof(struct edma_soc_info), + EDMA_MAX_CC*sizeof(struct edma_soc_info), GFP_KERNEL); edma_of_parse_dt(dev, node, pdata); info = &pdata;