| Message ID | 20140423224035.1de64093@gandalf.local.home (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 259a527009e3f5b049d2aa7fc0e62e8062cb1ac3 |
| Headers | show |
On Wed, Apr 23, 2014 at 10:40:35PM -0400, Steven Rostedt wrote: > Running my ktest.pl tests on all the archs, I stumbled over this for > 3.15-rc2: Applied, thanks.
On Thu, Apr 24, 2014 at 11:33:29AM +0100, Mark Brown wrote: > On Wed, Apr 23, 2014 at 10:40:35PM -0400, Steven Rostedt wrote: > > Running my ktest.pl tests on all the archs, I stumbled over this for > > 3.15-rc2: > > Applied, thanks. Actually not - I already have a fix for this in -next (on a slightly different branch to the one I looked for it on). Anyway, it's fixed.
On Thu, 24 Apr 2014 12:33:46 +0100 Mark Brown <broonie@kernel.org> wrote: > On Thu, Apr 24, 2014 at 11:33:29AM +0100, Mark Brown wrote: > > On Wed, Apr 23, 2014 at 10:40:35PM -0400, Steven Rostedt wrote: > > > Running my ktest.pl tests on all the archs, I stumbled over this for > > > 3.15-rc2: > > > > Applied, thanks. > > Actually not - I already have a fix for this in -next (on a slightly > different branch to the one I looked for it on). Anyway, it's fixed. Heh, OK, I figured someone may have already fixed it, but still wanted to let people know it was broken. It's amazing how long something like this can take. It's just annoying when my tests break on something that I'm not testing ;-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 24, 2014 at 08:34:32AM -0400, Steven Rostedt wrote: > It's just annoying when my tests break on something that I'm not > testing ;-) With something like this clearly you are testing it, even if you didn't mean to!
diff --git a/drivers/spi/spi-bfin5xx.c b/drivers/spi/spi-bfin5xx.c index 55e57c3..da8baa5 100644 --- a/drivers/spi/spi-bfin5xx.c +++ b/drivers/spi/spi-bfin5xx.c @@ -15,6 +15,7 @@ #include <linux/slab.h> #include <linux/io.h> #include <linux/ioport.h> +#include <linux/gpio.h> #include <linux/irq.h> #include <linux/errno.h> #include <linux/interrupt.h>
Running my ktest.pl tests on all the archs, I stumbled over this for 3.15-rc2: drivers/spi/spi-bfin5xx.c: In function 'bfin_spi_cs_active': drivers/spi/spi-bfin5xx.c:169:3: error: implicit declaration of function 'gpio_set_value' [-Werror=implicit-function-declaration] drivers/spi/spi-bfin5xx.c: In function 'bfin_spi_setup': drivers/spi/spi-bfin5xx.c:1097:4: error: implicit declaration of function 'gpio_request' [-Werror=implicit-function-declaration] drivers/spi/spi-bfin5xx.c:1102:4: error: implicit declaration of function 'gpio_direction_output' [-Werror=implicit-function-declaration] drivers/spi/spi-bfin5xx.c:1130:3: error: implicit declaration of function 'gpio_free' [-Werror=implicit-function-declaration] The problem is that the spi-bfin5xx driver is missing an include for the gpio.h file. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html