From patchwork Thu Apr 24 02:40:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 4045541 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D30069F387 for ; Thu, 24 Apr 2014 02:41:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DF9C520165 for ; Thu, 24 Apr 2014 02:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F34CD2015E for ; Thu, 24 Apr 2014 02:41:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbaDXClk (ORCPT ); Wed, 23 Apr 2014 22:41:40 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:9472 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751269AbaDXClj (ORCPT ); Wed, 23 Apr 2014 22:41:39 -0400 Received: from [67.246.153.56] ([67.246.153.56:53340] helo=gandalf.local.home) by cdptpa-oedge02 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 18/E5-01721-4A978535; Thu, 24 Apr 2014 02:40:37 +0000 Date: Wed, 23 Apr 2014 22:40:35 -0400 From: Steven Rostedt To: Steven Miao , LKML , adi-buildroot-devel@lists.sourceforge.net Cc: Mark Brown , linux-spi@vger.kernel.org Subject: [PATCH] spi-bfin: Add missing gpio.h include Message-ID: <20140423224035.1de64093@gandalf.local.home> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Running my ktest.pl tests on all the archs, I stumbled over this for 3.15-rc2: drivers/spi/spi-bfin5xx.c: In function 'bfin_spi_cs_active': drivers/spi/spi-bfin5xx.c:169:3: error: implicit declaration of function 'gpio_set_value' [-Werror=implicit-function-declaration] drivers/spi/spi-bfin5xx.c: In function 'bfin_spi_setup': drivers/spi/spi-bfin5xx.c:1097:4: error: implicit declaration of function 'gpio_request' [-Werror=implicit-function-declaration] drivers/spi/spi-bfin5xx.c:1102:4: error: implicit declaration of function 'gpio_direction_output' [-Werror=implicit-function-declaration] drivers/spi/spi-bfin5xx.c:1130:3: error: implicit declaration of function 'gpio_free' [-Werror=implicit-function-declaration] The problem is that the spi-bfin5xx driver is missing an include for the gpio.h file. Signed-off-by: Steven Rostedt --- -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/spi/spi-bfin5xx.c b/drivers/spi/spi-bfin5xx.c index 55e57c3..da8baa5 100644 --- a/drivers/spi/spi-bfin5xx.c +++ b/drivers/spi/spi-bfin5xx.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include