diff mbox

spi: checking for NULL instead of IS_ERR

Message ID 20160212063833.GB22756@mwanda (mailing list archive)
State Accepted
Commit 657d32efe04197736ed328a34ba659b5172c8cce
Headers show

Commit Message

Dan Carpenter Feb. 12, 2016, 6:38 a.m. UTC 
spi_replace_transfers() returns error pointers on error, it never
returns NULL.

Fixes: d9f121227281 ('spi: core: add spi_split_transfers_maxsize')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 1413a6b..d459adc 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2284,8 +2284,8 @@  int __spi_split_transfer_maxsize(struct spi_master *master,
 
 	/* create replacement */
 	srt = spi_replace_transfers(msg, xfer, 1, count, NULL, 0, gfp);
-	if (!srt)
-		return -ENOMEM;
+	if (IS_ERR(srt))
+		return PTR_ERR(srt);
 	xfers = srt->inserted_transfers;
 
 	/* now handle each of those newly inserted spi_transfers