From patchwork Sat Jul 2 08:42:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhaktipriya Shridhar X-Patchwork-Id: 9210755 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E8E0060752 for ; Sat, 2 Jul 2016 08:42:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D776F28571 for ; Sat, 2 Jul 2016 08:42:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA63D286CE; Sat, 2 Jul 2016 08:42:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 710A528571 for ; Sat, 2 Jul 2016 08:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751202AbcGBImG (ORCPT ); Sat, 2 Jul 2016 04:42:06 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:36335 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbcGBImE (ORCPT ); Sat, 2 Jul 2016 04:42:04 -0400 Received: by mail-pa0-f68.google.com with SMTP id lm4so305756pab.3; Sat, 02 Jul 2016 01:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=RD5WzlZAtY9dsfXTBwA/3y3xL0d7xTqcj4pLv11KKiY=; b=krg5bDrdB/3XHbo3968gH4Kd1w7VqEr13XPYkQi0zBvGttolBBkIMf3QIQILR/ue7X lCex5qQ9Ek2p04jFg7I3qf0jRRr63dkVZAfIG4yy/4u5gKgtgfkk0eAji3nI94d8ftKc a67Pfd5SzNLN8DcF6zrmkCYhSC5lxIqz8x9qug0IHD8T/rsgSqE762twp0hHM/uEHUdu nCIGAJFurf23HeJ/uYaoit8HtTh5uSSMpLRc2kNEFBvCa49Ht63B5Y17809lEHe0OVk5 gjxTt1374we4vgvxGf8aQ0HUMWQ7HQUcDtrmp50UkVEia0sdXVy/cQOgnIX134aku0Zz Qtjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=RD5WzlZAtY9dsfXTBwA/3y3xL0d7xTqcj4pLv11KKiY=; b=DLkleGNd2yslZIXvf73zVMzaH4v3L/Bs2abu9qD1G9mRw+u1HGqB4CKF4WTFwarCct jzHXhUmB3xtGRBdrwWoH8x8EANkMd4IBYKSOC4cpDkZE6LN4UxVJkd32if99C1uk0/Dw MKtyR2EKIU3vNfpHFx3ho0XbG19ewaxti6jFyHNydS/zoJ1CqQHFsOd5Z1bJd7+hRrWX X9h0tScINXXisdCFzD36M7WZZWRu5OfbPM+NEBRfFNbc90dfj6/rh5QdOxfmyOkX6Rm1 /2BUPRwiLdiAUPEeNvjysuLh7vpDs0PSaQYdo66MzkktfrOVewi6TGEYNb2Y53XhPTFa 4rjw== X-Gm-Message-State: ALyK8tKvwz1cHY+AFhREp96cYe1kPXqs8r2EWwWGXqYWNsr3H1WFmN0kfNy3X4h7kByysA== X-Received: by 10.66.51.42 with SMTP id h10mr4311371pao.31.1467448923133; Sat, 02 Jul 2016 01:42:03 -0700 (PDT) Received: from Karyakshetra ([2401:fa00:c:fd01:410d:2f25:536:9c8f]) by smtp.gmail.com with ESMTPSA id ff9sm6654680pac.5.2016.07.02.01.42.01 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Jul 2016 01:42:02 -0700 (PDT) Date: Sat, 2 Jul 2016 14:12:00 +0530 From: Bhaktipriya Shridhar To: Mark Brown Cc: Tejun Heo , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: spi-bfin5xx: Remove deprecated create_singlethread_workqueue Message-ID: <20160702084200.GA27584@Karyakshetra> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The workqueue "workqueue" serves as a driver message queue. It has a single work item(&drv_data->pump_messages) and hence doesn't require ordering. Also, it is not being used on a memory reclaim path. Hence, the singlethreaded workqueue has been replaced with the use of system_wq. System workqueues have been able to handle high level of concurrency for a long time now and hence it's not required to have a singlethreaded workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue created with create_singlethread_workqueue(), system_wq allows multiple work items to overlap executions even on the same CPU; however, a per-cpu workqueue doesn't have any CPU locality or global ordering guarantee unless the target CPU is explicitly specified and thus the increase of local concurrency shouldn't make any difference. Work item has been flushed in bfin_spi_destroy_queue() to ensure that there are no pending tasks while disconnecting the driver. Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo --- drivers/spi/spi-bfin5xx.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/spi/spi-bfin5xx.c b/drivers/spi/spi-bfin5xx.c index 1e91325..249c7a3 100644 --- a/drivers/spi/spi-bfin5xx.c +++ b/drivers/spi/spi-bfin5xx.c @@ -67,8 +67,6 @@ struct bfin_spi_master_data { /* BFIN hookup */ struct bfin5xx_spi_master *master_info; - /* Driver message queue */ - struct workqueue_struct *workqueue; struct work_struct pump_messages; spinlock_t lock; struct list_head queue; @@ -359,7 +357,7 @@ static void bfin_spi_giveback(struct bfin_spi_master_data *drv_data) drv_data->cur_msg = NULL; drv_data->cur_transfer = NULL; drv_data->cur_chip = NULL; - queue_work(drv_data->workqueue, &drv_data->pump_messages); + schedule_work(&drv_data->pump_messages); spin_unlock_irqrestore(&drv_data->lock, flags); msg->state = NULL; @@ -946,7 +944,7 @@ static int bfin_spi_transfer(struct spi_device *spi, struct spi_message *msg) list_add_tail(&msg->queue, &drv_data->queue); if (drv_data->running && !drv_data->busy) - queue_work(drv_data->workqueue, &drv_data->pump_messages); + schedule_work(&drv_data->pump_messages); spin_unlock_irqrestore(&drv_data->lock, flags); @@ -1177,12 +1175,7 @@ static int bfin_spi_init_queue(struct bfin_spi_master_data *drv_data) tasklet_init(&drv_data->pump_transfers, bfin_spi_pump_transfers, (unsigned long)drv_data); - /* init messages workqueue */ INIT_WORK(&drv_data->pump_messages, bfin_spi_pump_messages); - drv_data->workqueue = create_singlethread_workqueue( - dev_name(drv_data->master->dev.parent)); - if (drv_data->workqueue == NULL) - return -EBUSY; return 0; } @@ -1204,7 +1197,7 @@ static int bfin_spi_start_queue(struct bfin_spi_master_data *drv_data) drv_data->cur_chip = NULL; spin_unlock_irqrestore(&drv_data->lock, flags); - queue_work(drv_data->workqueue, &drv_data->pump_messages); + schedule_work(&drv_data->pump_messages); return 0; } @@ -1246,7 +1239,7 @@ static int bfin_spi_destroy_queue(struct bfin_spi_master_data *drv_data) if (status != 0) return status; - destroy_workqueue(drv_data->workqueue); + flush_work(&drv_data->pump_messages); return 0; }