From patchwork Sat Jul 2 08:59:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhaktipriya Shridhar X-Patchwork-Id: 9210771 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 42D9D607D6 for ; Sat, 2 Jul 2016 08:59:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 31AD52857B for ; Sat, 2 Jul 2016 08:59:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2593528545; Sat, 2 Jul 2016 08:59:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B754828545 for ; Sat, 2 Jul 2016 08:59:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750939AbcGBI7q (ORCPT ); Sat, 2 Jul 2016 04:59:46 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:32874 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbcGBI7p (ORCPT ); Sat, 2 Jul 2016 04:59:45 -0400 Received: by mail-pa0-f66.google.com with SMTP id ts6so11591253pac.0; Sat, 02 Jul 2016 01:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=XNLZluszQ/+Yd+Z+ocSt5p5z1GupyulghuNewyR66ng=; b=nHb3pRt3TFlJ8wpuwIblAJ6EKlQW8ATYekuNkhnetPTSHy46yNoBi5JgfoDa3MhY28 959V4NieNH2VOoY6SJHDbXh8X78oMl2KXi0q19u2mCIeCkvbKc9bTb/tKEmRxpflE0rz CzlBKGnvqhesaVzkfdKpyDeUG5c1CpEs4D2MQiWg3e0zo+Zpq6Sr8O00njSDt2f+t9Sk t+IeKePabXPgvBESyn0w57vZ9sY9UMzBV9Gqj/PRfJXrA5M1K/ON1dDRCg/htmLO7jli sOvO0HSEyxrND0KYbN/i3VFWhpoX7A868WvSjW1UukNEeP97dOVTryMzL2bz0n6gBiHX 0v0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=XNLZluszQ/+Yd+Z+ocSt5p5z1GupyulghuNewyR66ng=; b=UGKRQCDJ6GZUAEHkDppJE8WBVUwGa7bdWreBY0RAnV+hhQKAXGCWgmRstkAZBQ2ZYK oMEDyQ4a2JNU5ZHDkOmzjZpnG5DllDo6NGW2yLCsEo3poRT6I24V/ekDGqno69+yl/AQ 9DIstGqJhBF60cgP3XlOvGZ32fLCzhIlUD6C0Lsj+AHNMktyvWhEB0VFM5YyWOCpyf/U tK9LwEyiB9VXufjRDp28CowrDeZhpsXTCGFlRBocrDjAz5Ee5axwUFgKfRjR/pm6kDYd xz+QBifAsvcJ/Rm8okkGT+jy7t69cz71KtFwiNtI1qgN9ofYAL9X2QwEqx+IYqeSJ3oM +htQ== X-Gm-Message-State: ALyK8tJshjhhzzq+1PihkdPxFbHuyL26Ib7TUeNDpE5KU/+714Omyb/wKdWIhjhPXlGwQg== X-Received: by 10.66.253.38 with SMTP id zx6mr4355292pac.19.1467449984053; Sat, 02 Jul 2016 01:59:44 -0700 (PDT) Received: from Karyakshetra ([2401:fa00:c:fd01:410d:2f25:536:9c8f]) by smtp.gmail.com with ESMTPSA id y70sm3105834pff.25.2016.07.02.01.59.43 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Jul 2016 01:59:43 -0700 (PDT) Date: Sat, 2 Jul 2016 14:29:41 +0530 From: Bhaktipriya Shridhar To: Mark Brown Cc: Tejun Heo , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: spi-bfin-sport: Remove deprecated create_singlethread_workqueue Message-ID: <20160702085941.GA28900@Karyakshetra> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The workqueue "workqueue" serves as a driver message queue. It has a single work item(&drv_data->pump_messages) and hence doesn't require ordering. Also, it is not being used on a memory reclaim path. Hence, the singlethreaded workqueue has been replaced with the use of system_wq. System workqueues have been able to handle high level of concurrency for a long time now and hence it's not required to have a singlethreaded workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue created with create_singlethread_workqueue(), system_wq allows multiple work items to overlap executions even on the same CPU; however, a per-cpu workqueue doesn't have any CPU locality or global ordering guarantee unless the target CPU is explicitly specified and thus the increase of local concurrency shouldn't make any difference. Work item has been flushed in bfin_sport_spi_destroy_queue() to ensure that there are no pending tasks while disconnecting the driver. Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo --- drivers/spi/spi-bfin-sport.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/spi/spi-bfin-sport.c b/drivers/spi/spi-bfin-sport.c index 6c96755..01d0ba9 100644 --- a/drivers/spi/spi-bfin-sport.c +++ b/drivers/spi/spi-bfin-sport.c @@ -64,8 +64,6 @@ struct bfin_sport_spi_master_data { /* Pin request list */ u16 *pin_req; - /* Driver message queue */ - struct workqueue_struct *workqueue; struct work_struct pump_messages; spinlock_t lock; struct list_head queue; @@ -300,7 +298,7 @@ bfin_sport_spi_giveback(struct bfin_sport_spi_master_data *drv_data) drv_data->cur_msg = NULL; drv_data->cur_transfer = NULL; drv_data->cur_chip = NULL; - queue_work(drv_data->workqueue, &drv_data->pump_messages); + schedule_work(&drv_data->pump_messages); spin_unlock_irqrestore(&drv_data->lock, flags); if (!drv_data->cs_change) @@ -556,7 +554,7 @@ bfin_sport_spi_transfer(struct spi_device *spi, struct spi_message *msg) list_add_tail(&msg->queue, &drv_data->queue); if (drv_data->run && !drv_data->busy) - queue_work(drv_data->workqueue, &drv_data->pump_messages); + schedule_work(&drv_data->pump_messages); spin_unlock_irqrestore(&drv_data->lock, flags); @@ -666,12 +664,7 @@ bfin_sport_spi_init_queue(struct bfin_sport_spi_master_data *drv_data) tasklet_init(&drv_data->pump_transfers, bfin_sport_spi_pump_transfers, (unsigned long)drv_data); - /* init messages workqueue */ INIT_WORK(&drv_data->pump_messages, bfin_sport_spi_pump_messages); - drv_data->workqueue = - create_singlethread_workqueue(dev_name(drv_data->master->dev.parent)); - if (drv_data->workqueue == NULL) - return -EBUSY; return 0; } @@ -694,7 +687,7 @@ bfin_sport_spi_start_queue(struct bfin_sport_spi_master_data *drv_data) drv_data->cur_chip = NULL; spin_unlock_irqrestore(&drv_data->lock, flags); - queue_work(drv_data->workqueue, &drv_data->pump_messages); + schedule_work(&drv_data->pump_messages); return 0; } @@ -738,7 +731,7 @@ bfin_sport_spi_destroy_queue(struct bfin_sport_spi_master_data *drv_data) if (status) return status; - destroy_workqueue(drv_data->workqueue); + flush_work(&drv_data->pump_messages); return 0; }