diff mbox

[2/2] dt-bindings: spi: add binding for clps711x SPI

Message ID 20160706145326.2658600-2-arnd@arndb.de (mailing list archive)
State Accepted
Commit ea2ff61ba3f8239483f5cd823ac0113d194b469f
Headers show

Commit Message

Arnd Bergmann July 6, 2016, 2:53 p.m. UTC
This documents the binding used by Alexander Shiyan's DT support for
the clps711x SPI controller.

I've left the file name to match the ARM platform port name "clps711x"
for consistency with the other bindings, even though the compatible
string refers to the later ep7309 chip.

Linux no longer supports the old clps711x and ep72xx product lines,
but we still use the name. The entire family is now discontinued
by the manufacturer.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Alexander Shiyan <shc_work@mail.ru>
---
 .../devicetree/bindings/spi/spi-clps711x.txt       | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/spi/spi-clps711x.txt

Comments

Mark Brown July 7, 2016, 9:25 a.m. UTC | #1
On Wed, Jul 06, 2016 at 04:53:13PM +0200, Arnd Bergmann wrote:
> This documents the binding used by Alexander Shiyan's DT support for
> the clps711x SPI controller.

Please use subject lines matching the style for the subsystem.  This
makes it easier for people to identify relevant patches.
Arnd Bergmann July 7, 2016, 9:48 a.m. UTC | #2
On Thursday, July 7, 2016 11:25:46 AM CEST Mark Brown wrote:
> On Wed, Jul 06, 2016 at 04:53:13PM +0200, Arnd Bergmann wrote:
> > This documents the binding used by Alexander Shiyan's DT support for
> > the clps711x SPI controller.
> 
> Please use subject lines matching the style for the subsystem.  This
> makes it easier for people to identify relevant patches.

I tried, though it's a bit tricky for dt-bindings. When I created the
patch, using 'dt-bindings: $SUBSYSTEM' appeared to be the most common
one, ahead of '$SUBSYSTEM' (mainly used for combined patches)
and other random prefixes.

I'll resend it with just 'spi:', but I don't think there is a broad
consensus on this in the existing patches.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring (Arm) July 11, 2016, 2:42 p.m. UTC | #3
On Thu, Jul 07, 2016 at 11:48:25AM +0200, Arnd Bergmann wrote:
> On Thursday, July 7, 2016 11:25:46 AM CEST Mark Brown wrote:
> > On Wed, Jul 06, 2016 at 04:53:13PM +0200, Arnd Bergmann wrote:
> > > This documents the binding used by Alexander Shiyan's DT support for
> > > the clps711x SPI controller.
> > 
> > Please use subject lines matching the style for the subsystem.  This
> > makes it easier for people to identify relevant patches.
> 
> I tried, though it's a bit tricky for dt-bindings. When I created the
> patch, using 'dt-bindings: $SUBSYSTEM' appeared to be the most common
> one, ahead of '$SUBSYSTEM' (mainly used for combined patches)
> and other random prefixes.

There isn't. Mark and I don't agree here as the former is my 
preference, but I care less than he does. :) 

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/spi/spi-clps711x.txt b/Documentation/devicetree/bindings/spi/spi-clps711x.txt
new file mode 100644
index 000000000000..4c3ec13f423f
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/spi-clps711x.txt
@@ -0,0 +1,33 @@ 
+Serial Peripheral Interface on Cirrus Logic CL-PS71xx, EP72xx, EP73xx
+
+Required properties
+- #address-cells: must be <1>
+- #size-cells: must be <0>
+- compatible: should include "cirrus,ep7209-spi"
+- reg: Address and length of one register range
+- interrupts: one interrupt line
+- clocks: One entry, refers to the SPI bus clock
+- cs-gpios: Specifies the gpio pins to be used for chipselects.
+	    See: Documentation/devicetree/bindings/spi/spi-bus.txt
+
+An additional register is present in the system controller,
+which is assumed to be in the same device tree, with and marked
+as compatible with "cirrus,ep7209-syscon3".
+
+Example:
+
+spi@80000500 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	compatible = "cirrus,ep7209-spi";
+	reg = <0x80000500 0x4>;
+	interrupts = <15>;
+	clocks = <&clks CLPS711X_CLK_SPI>;
+	status = "disabled";
+};
+
+syscon3: syscon@80002200 {
+	compatible = "cirrus,ep7209-syscon3", "syscon";
+	reg = <0x80002200 0x40>;
+};
+