| Message ID | 20161115182643.32217-1-prahlad.eee@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d06a3507fe7cfd85a296d2c1fe367dd850e9595f |
| Headers | show |
Did anybody got chance to review this patch? I feel this is a trivial yet required fix. On Tue, Nov 15, 2016 at 11:56 PM, Prahlad V <prahlad.eee@gmail.com> wrote: > > completion variable should be reinitialized before reusing. > > Signed-off-by: Prahlad V <prahlad.eee@gmail.com> > --- > drivers/spi/spi-ti-qspi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c > index caeac66..ec6fb09 100644 > --- a/drivers/spi/spi-ti-qspi.c > +++ b/drivers/spi/spi-ti-qspi.c > @@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst, > tx->callback = ti_qspi_dma_callback; > tx->callback_param = qspi; > cookie = tx->tx_submit(tx); > + reinit_completion(&qspi->transfer_complete); > > ret = dma_submit_error(cookie); > if (ret) { > -- > 2.9.2.729.ga42d7b6 >
On Tue, Nov 22, 2016 at 12:54:06PM +0530, prahlad venkata wrote: > Did anybody got chance to review this patch? > I feel this is a trivial yet required fix. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled. Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed.
diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c index caeac66..ec6fb09 100644 --- a/drivers/spi/spi-ti-qspi.c +++ b/drivers/spi/spi-ti-qspi.c @@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst, tx->callback = ti_qspi_dma_callback; tx->callback_param = qspi; cookie = tx->tx_submit(tx); + reinit_completion(&qspi->transfer_complete); ret = dma_submit_error(cookie); if (ret) {
completion variable should be reinitialized before reusing. Signed-off-by: Prahlad V <prahlad.eee@gmail.com> --- drivers/spi/spi-ti-qspi.c | 1 + 1 file changed, 1 insertion(+)