| Message ID | 20161129143939.3191-5-romain.perier@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello, On Tue, 29 Nov 2016 15:39:38 +0100, Romain Perier wrote: > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > index e9bd587..84e4f57 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -98,6 +98,19 @@ > /* 32M internal register @ 0xd000_0000 */ > ranges = <0x0 0x0 0xd0000000 0x2000000>; > > + spi0: spi@10600 { > + compatible = "marvell,armada-3700-spi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x10600 0x5d>; > + clocks = <&nb_periph_clk 7>; > + clock-frequency = <200000000>; This property. > + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; > + max-frequency = <66000000>; And this one no longer exist in your DT binding, so I guess they should be removed from here as well. (Please wait for other reviews, don't respin just for that issue.) Thanks! Thomas
Hello, Le 29/11/2016 à 15:51, Thomas Petazzoni a écrit : > >> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi >> index e9bd587..84e4f57 100644 >> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi >> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi >> @@ -98,6 +98,19 @@ >> /* 32M internal register @ 0xd000_0000 */ >> ranges = <0x0 0x0 0xd0000000 0x2000000>; >> >> + spi0: spi@10600 { >> + compatible = "marvell,armada-3700-spi"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0x10600 0x5d>; >> + clocks = <&nb_periph_clk 7>; >> + clock-frequency = <200000000>; > > This property. > >> + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; >> + max-frequency = <66000000>; > > And this one no longer exist in your DT binding, so I guess they should > be removed from here as well. > Good point, I was pretty sure that I have removed these. I probably did something wrong with my rebase. Thanks, Romain -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi index e9bd587..84e4f57 100644 --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi @@ -98,6 +98,19 @@ /* 32M internal register @ 0xd000_0000 */ ranges = <0x0 0x0 0xd0000000 0x2000000>; + spi0: spi@10600 { + compatible = "marvell,armada-3700-spi"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x10600 0x5d>; + clocks = <&nb_periph_clk 7>; + clock-frequency = <200000000>; + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; + max-frequency = <66000000>; + num-cs = <4>; + status = "disabled"; + }; + uart0: serial@12000 { compatible = "marvell,armada-3700-uart"; reg = <0x12000 0x400>;
Armada 3700 SoC has an SPI Controller, this commit adds the definition of the SPI device node at the SoC level. Signed-off-by: Romain Perier <romain.perier@free-electrons.com> --- arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)