| Message ID | 20161209194853.71018-2-nbd@nbd.name (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 91829a9a25cc931b76b01aa091a52e0edd649a72 |
| Headers | show |
Hi Felix, On Fri, Dec 9, 2016 at 8:48 PM, Felix Fietkau <nbd@nbd.name> wrote: > Signed-off-by: Felix Fietkau <nbd@nbd.name> Please explain why this is needed, instead of just translating C to English. A good patch description explains what, why, and how. Thanks! > --- > drivers/spi/spi-ath79.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c > index d51c99a..2517e1e 100644 > --- a/drivers/spi/spi-ath79.c > +++ b/drivers/spi/spi-ath79.c > @@ -80,7 +80,7 @@ static void ath79_spi_chipselect(struct spi_device *spi, int is_active) > > if (gpio_is_valid(spi->cs_gpio)) { > /* SPI is normally active-low */ > - gpio_set_value(spi->cs_gpio, cs_high); > + gpio_set_value_cansleep(spi->cs_gpio, cs_high); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c index d51c99a..2517e1e 100644 --- a/drivers/spi/spi-ath79.c +++ b/drivers/spi/spi-ath79.c @@ -80,7 +80,7 @@ static void ath79_spi_chipselect(struct spi_device *spi, int is_active) if (gpio_is_valid(spi->cs_gpio)) { /* SPI is normally active-low */ - gpio_set_value(spi->cs_gpio, cs_high); + gpio_set_value_cansleep(spi->cs_gpio, cs_high); } else { u32 cs_bit = AR71XX_SPI_IOC_CS(spi->chip_select);
Signed-off-by: Felix Fietkau <nbd@nbd.name> --- drivers/spi/spi-ath79.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)