| Message ID | 20170109000247.3215-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9620ca90115d4bd700f05862d3b210a266a66efe |
| Headers | show |
On 01/09/2017 01:02 AM, Christophe JAILLET wrote: > We should go to 'err_put_master' here instead of returning directly. > Otherwise a call to 'spi_master_put' is missing. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Thanks. Acked-by: Lars-Peter Clausen <lars@metafoo.de> > --- > drivers/spi/spi-axi-spi-engine.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c > index 319225d7e761..6ab4c7700228 100644 > --- a/drivers/spi/spi-axi-spi-engine.c > +++ b/drivers/spi/spi-axi-spi-engine.c > @@ -494,7 +494,8 @@ static int spi_engine_probe(struct platform_device *pdev) > SPI_ENGINE_VERSION_MAJOR(version), > SPI_ENGINE_VERSION_MINOR(version), > SPI_ENGINE_VERSION_PATCH(version)); > - return -ENODEV; > + ret = -ENODEV; > + goto err_put_master; > } > > spi_engine->clk = devm_clk_get(&pdev->dev, "s_axi_aclk"); > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c index 319225d7e761..6ab4c7700228 100644 --- a/drivers/spi/spi-axi-spi-engine.c +++ b/drivers/spi/spi-axi-spi-engine.c @@ -494,7 +494,8 @@ static int spi_engine_probe(struct platform_device *pdev) SPI_ENGINE_VERSION_MAJOR(version), SPI_ENGINE_VERSION_MINOR(version), SPI_ENGINE_VERSION_PATCH(version)); - return -ENODEV; + ret = -ENODEV; + goto err_put_master; } spi_engine->clk = devm_clk_get(&pdev->dev, "s_axi_aclk");
We should go to 'err_put_master' here instead of returning directly. Otherwise a call to 'spi_master_put' is missing. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/spi/spi-axi-spi-engine.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)