From patchwork Thu Jul 26 15:02:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 10546021 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5D7849093 for ; Thu, 26 Jul 2018 15:02:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D6E12B457 for ; Thu, 26 Jul 2018 15:02:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 41B1C2B45D; Thu, 26 Jul 2018 15:02:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D90D12B457 for ; Thu, 26 Jul 2018 15:02:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730105AbeGZQTg (ORCPT ); Thu, 26 Jul 2018 12:19:36 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:48530 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729801AbeGZQTg (ORCPT ); Thu, 26 Jul 2018 12:19:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=HhJOZRT/+lH0SlNWGXWBrLaIn2UBryNgh/+MA+5VREo=; b=cDgKRNYad5h2 1kyOunM8Xbh+DxhrWdPy8WF1RJvwPM4zUHPtcmjJMh9FyF7VyTBnHtKLqh6emB5UCnUac5oAN5bUf 6qfDpX8GepYYP39/CqTG+JO5RyGEOKxnAu4i1LbGgcACQqjh80EuN1OSy5FMPmlzQl2PKEPRd8x3k VCyjc=; Received: from host86-168-121-229.range86-168.btcentralplus.com ([86.168.121.229] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fihmT-0007hA-Sv; Thu, 26 Jul 2018 15:02:17 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 69D74440078; Thu, 26 Jul 2018 16:02:17 +0100 (BST) From: Mark Brown To: Tiago Brusamarello Cc: Mark Brown , broonie@kernel.org, linux-spi@vger.kernel.org, linux-spi@vger.kernel.org Subject: Applied "spi: spi-fsl-espi: Log fifo counters on error" to the spi tree In-Reply-To: <1532614331-12663-1-git-send-email-tiago.brusamarello@datacom.ind.br> Message-Id: <20180726150217.69D74440078@finisterre.ee.mobilebroadband> Date: Thu, 26 Jul 2018 16:02:17 +0100 (BST) Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The patch spi: spi-fsl-espi: Log fifo counters on error has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 516ddd79068dc02b9101bf9551a9ef7dce217b5b Mon Sep 17 00:00:00 2001 From: Tiago Brusamarello Date: Thu, 26 Jul 2018 11:12:11 -0300 Subject: [PATCH] spi: spi-fsl-espi: Log fifo counters on error Log RX and TX fifo counters when a transfer is done and these are not zero. Signed-off-by: Tiago Brusamarello Signed-off-by: Mark Brown --- drivers/spi/spi-fsl-espi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c index 1d332e23f6ed..1e8ff6256079 100644 --- a/drivers/spi/spi-fsl-espi.c +++ b/drivers/spi/spi-fsl-espi.c @@ -547,8 +547,11 @@ static void fsl_espi_cpu_irq(struct fsl_espi *espi, u32 events) dev_err(espi->dev, "Transfer done but SPIE_DON isn't set!\n"); - if (SPIE_RXCNT(events) || SPIE_TXCNT(events) != FSL_ESPI_FIFO_SIZE) + if (SPIE_RXCNT(events) || SPIE_TXCNT(events) != FSL_ESPI_FIFO_SIZE) { dev_err(espi->dev, "Transfer done but rx/tx fifo's aren't empty!\n"); + dev_err(espi->dev, "SPIE_RXCNT = %d, SPIE_TXCNT = %d\n", + SPIE_RXCNT(events), SPIE_TXCNT(events)); + } complete(&espi->done); }