From patchwork Tue Oct 2 10:10:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 10623335 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 348681926 for ; Tue, 2 Oct 2018 10:10:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 31484287E9 for ; Tue, 2 Oct 2018 10:10:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 25743287EF; Tue, 2 Oct 2018 10:10:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CCA8F287E9 for ; Tue, 2 Oct 2018 10:10:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbeJBQwv (ORCPT ); Tue, 2 Oct 2018 12:52:51 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44517 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726194AbeJBQwv (ORCPT ); Tue, 2 Oct 2018 12:52:51 -0400 Received: by mail-pl1-f193.google.com with SMTP id p25-v6so886124pli.11 for ; Tue, 02 Oct 2018 03:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=uomRvr0igxgzTEohcGLyB7R8DkySqJ8fScScV3p/Xhw=; b=LtqH2JCprTegkEF8NgTDqmhWz5vqjEsFSr9m4yO4lPqJkiKASmtL42OcPGVOPC25wY 7vMBkHFVmA3ep1YVBhAPeToOyohNnQesgdbu+7EG/xIvQhJqlVwS7Owe0zIVaXYoMPGK QMfMGHQOS1gO9qtloEAxMgE3L/F8wzBCyi1ttb/igZJtv+uqHtARE4B5Xp8ZJkqtDL6H ojVFTIR73WEBMNeDpaLdKz0rdwPMf3hOTzX269kH9qx3SWTqyMtHDacMFCjxcwYBFOHg hF0q5tOk5764WrWyFltpCIf+okU9QRQ+uC5v8fwo0/WlpGpLDHHC2WB4biyqAkGwQ33t vB8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uomRvr0igxgzTEohcGLyB7R8DkySqJ8fScScV3p/Xhw=; b=gayVz76zDk4cXKpM8HxG0T0w2QqL66MWTdYlfl82Hv3u8zJO5hVVpT7H0WS90Q0dJn r0zWvRIMdXaEcym9iNcOhHeqilYJBtsnRvu3wFvjaKR2Z/rxaeD3VMUjl6ntsR3rNxUH 8ZBrmyvhYGYZVNA7dbidvzs53d7W2Ki+HR966YDkoU/VAYV3OwuAb4CJENLaQO1/ADAs KY22Xb0N42ROUj2R+hNtDrC4F+G2DPTwbMsiOEmgubXoGm1COLXqwzuPcg4hniONQAgy cQpQBc14iHAHqUW3kk/GBVWwLeXNrNy+kbZbnhoY8m00Ro9oSrO18SYwGeolGmnZpDn5 sdQQ== X-Gm-Message-State: ABuFfojys4lsh0HmZVFxKSrj72Fxny2HciQ75UnSTSkluRNBDBfYoe1y DO5obe84vHM2gDpZ6Z8usZcyrQ== X-Google-Smtp-Source: ACcGV61CqYQBeODtjVoEbLfz8FTFIl78f40sL/9UabWM3zMOYUaMuupJDRZvg2sL38L+vRYSuNocNQ== X-Received: by 2002:a62:14ce:: with SMTP id 197-v6mr15605465pfu.50.1538475020427; Tue, 02 Oct 2018 03:10:20 -0700 (PDT) Received: from localhost.localdomain (220-133-186-239.HINET-IP.hinet.net. [220.133.186.239]) by smtp.gmail.com with ESMTPSA id j15-v6sm19729489pfn.52.2018.10.02.03.10.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 03:10:19 -0700 (PDT) From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Mark Brown , Radu Pirea , Nicolas Ferre , Lee Jones , linux-spi@vger.kernel.org, Axel Lin Subject: [PATCH] spi: at91-usart: Remove duplicated checking for spi->bits_per_word Date: Tue, 2 Oct 2018 18:10:10 +0800 Message-Id: <20181002101010.29723-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.17.1 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This checking is already done in __spi_validate_bits_per_word(). Signed-off-by: Axel Lin Acked-by: Nicolas Ferre --- drivers/spi/spi-at91-usart.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c index a924657642fa..519853f14934 100644 --- a/drivers/spi/spi-at91-usart.c +++ b/drivers/spi/spi-at91-usart.c @@ -176,12 +176,6 @@ static int at91_usart_spi_setup(struct spi_device *spi) struct at91_usart_spi *aus = spi_master_get_devdata(spi->controller); u32 *ausd = spi->controller_state; unsigned int mr = at91_usart_spi_readl(aus, MR); - u8 bits = spi->bits_per_word; - - if (bits != 8) { - dev_dbg(&spi->dev, "Only 8 bits per word are supported\n"); - return -EINVAL; - } if (spi->mode & SPI_CPOL) mr |= US_MR_CPOL; @@ -210,7 +204,7 @@ static int at91_usart_spi_setup(struct spi_device *spi) dev_dbg(&spi->dev, "setup: bpw %u mode 0x%x -> mr %d %08x\n", - bits, spi->mode, spi->chip_select, mr); + spi->bits_per_word, spi->mode, spi->chip_select, mr); return 0; }