| Message ID | 20181010134317.8466-2-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] eeprom: at25: Drop obsolete cast in at25_ee_write() | expand |
On 10/10/18, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Since commit 01973a01f9ec34b7 ("eeprom: at25: remove nvmem regmap > dependency") changed the type of "off" from "loff_t" to "unsigned int", > there is no longer a need to cast it to "unsigned". > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/misc/eeprom/at25.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c > index 840afb398f9e4c88..7707d3fb49b526d9 100644 > --- a/drivers/misc/eeprom/at25.c > +++ b/drivers/misc/eeprom/at25.c > @@ -160,7 +160,7 @@ static int at25_ee_write(void *priv, unsigned int off, > void *val, size_t count) > do { > unsigned long timeout, retries; > unsigned segment; > - unsigned offset = (unsigned) off; > + unsigned offset = off; > u8 *cp = bounce; > int sr; > u8 instr; > -- This looks correct, but why not remove the extra variable completely and rename 'off' to 'offset'? Arnd
Hi Arnd, On Wed, Oct 10, 2018 at 4:01 PM Arnd Bergmann <arnd@arndb.de> wrote: > On 10/10/18, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > Since commit 01973a01f9ec34b7 ("eeprom: at25: remove nvmem regmap > > dependency") changed the type of "off" from "loff_t" to "unsigned int", > > there is no longer a need to cast it to "unsigned". > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > drivers/misc/eeprom/at25.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c > > index 840afb398f9e4c88..7707d3fb49b526d9 100644 > > --- a/drivers/misc/eeprom/at25.c > > +++ b/drivers/misc/eeprom/at25.c > > @@ -160,7 +160,7 @@ static int at25_ee_write(void *priv, unsigned int off, > > void *val, size_t count) > > do { > > unsigned long timeout, retries; > > unsigned segment; > > - unsigned offset = (unsigned) off; > > + unsigned offset = off; > > u8 *cp = bounce; > > int sr; > > u8 instr; > > -- > > This looks correct, but why not remove the extra variable completely > and rename 'off' to 'offset'? Thanks, good point. Will do. Gr{oetje,eeting}s, Geert
diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c index 840afb398f9e4c88..7707d3fb49b526d9 100644 --- a/drivers/misc/eeprom/at25.c +++ b/drivers/misc/eeprom/at25.c @@ -160,7 +160,7 @@ static int at25_ee_write(void *priv, unsigned int off, void *val, size_t count) do { unsigned long timeout, retries; unsigned segment; - unsigned offset = (unsigned) off; + unsigned offset = off; u8 *cp = bounce; int sr; u8 instr;
Since commit 01973a01f9ec34b7 ("eeprom: at25: remove nvmem regmap dependency") changed the type of "off" from "loff_t" to "unsigned int", there is no longer a need to cast it to "unsigned". Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/misc/eeprom/at25.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)