From patchwork Sat Feb 9 23:38:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10804647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 47CFB13B5 for ; Sat, 9 Feb 2019 23:38:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A4BB29FDB for ; Sat, 9 Feb 2019 23:38:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1E03829FE7; Sat, 9 Feb 2019 23:38:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5E1929FDB for ; Sat, 9 Feb 2019 23:38:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727045AbfBIXic (ORCPT ); Sat, 9 Feb 2019 18:38:32 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:43189 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727012AbfBIXic (ORCPT ); Sat, 9 Feb 2019 18:38:32 -0500 Received: by mail-lf1-f65.google.com with SMTP id j1so5132863lfb.10 for ; Sat, 09 Feb 2019 15:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=z4pZ290CNrSCrbRqPjjC6mK1LTheq0eTUeZeXFQredU=; b=LDVzyYOG+vvgw4bOTFvmNyPn9KyiVLehD1HXhUY/iXKrQLFGGGzFptr3y095iaWxtY JCF8/91wOvghSFjMpErgKKwqyv1gTyMYuhLW3cT4WsT0o0c8rPq6FZc3R6q3cEEHxh7P Blgj1TB9N3/EQ16/sOW28xfaGCCws9gFCRUwjVOZIyAwdfpbFj4KVX+Aanm+QZMXReqa UpEUpsHErQX2GwGqCWg2BNsbUW4Pa2eSBsYmpxeuAbmLqpNuBbzi7O2k+G0+iAqJ+EDC pUUj247hAP9cjOi7MqOSPzA6lAcL/ylGOll83sH4M0yp6SY4Zp5Bhjslcg7bEa+u7Z1h MqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=z4pZ290CNrSCrbRqPjjC6mK1LTheq0eTUeZeXFQredU=; b=l7o4MDfXF9167/wok7KrhFVX/A2E5NltTE49e8cp5f0Yx05aG0egHE4QXo+EJukfU4 5Sv6vOnTWxgFYsxnaP5WQ8Y785DxjFNUWoXpd3JbaXpBD1MZcqOa2U8rX9APe4W47/xs GwpIPDIALk5DwEi30Xhg/mlgIDzkfkeaujPN8wtAVRK84+Pev6UJpTF/RmlEHB8DaRmp F8QpJdM+hxsdXVVQ7L5fJ0KEXm5eHn17COwBueq9Ukg10EOOtdCSyEyS8cqZMf9IMsIF /5q6c0FCf04yvIq0CUkvIHux78KE5ppHAV2By2jzEVQQ3CmoOcN3jmYomnA7nyjELQM1 00Ig== X-Gm-Message-State: AHQUAublSNuCz+hQ6Os/xA2FeqSyDRkezlw0OASkzKbhXKMlNge+5/D9 tpiqWuG5balFNz9cfLqFeMfsjlwXi9A= X-Google-Smtp-Source: AHgI3IbJYudT8yHykO0tYFwVbZE0RykEcc+ey66pq2OQ91tqp1ehV9HbQIqdqg0E70lYIXw6lRoKsg== X-Received: by 2002:a19:7609:: with SMTP id c9mr19228001lff.107.1549755510508; Sat, 09 Feb 2019 15:38:30 -0800 (PST) Received: from localhost.bredbandsbolaget (c-ae7b71d5.014-348-6c756e10.bbcust.telenor.se. [213.113.123.174]) by smtp.gmail.com with ESMTPSA id o6-v6sm1272246ljj.6.2019.02.09.15.38.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 09 Feb 2019 15:38:29 -0800 (PST) From: Linus Walleij To: Mark Brown , linux-spi@vger.kernel.org Cc: linux-gpio@vger.kernel.org, Felix Fietkau , Linus Walleij Subject: [PATCH] spi: use gpio[d]_set_value_cansleep for setting chipselect GPIO Date: Sun, 10 Feb 2019 00:38:25 +0100 Message-Id: <20190209233825.2883-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Felix Fietkau Sleeping is safe inside spi_transfer_one_message, and some GPIO chips are running on slow busses (such as I2C GPIO expanders) and need to sleep for setting values. Signed-off-by: Felix Fietkau Signed-off-by: Linus Walleij --- This patch was found in the OpenWrt tree, I adapted it for my recent changes to the SPI core. --- drivers/spi/spi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 2f7176f07591..93986f879b09 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -786,9 +786,10 @@ static void spi_set_cs(struct spi_device *spi, bool enable) */ if (!(spi->mode & SPI_NO_CS)) { if (spi->cs_gpiod) - gpiod_set_value(spi->cs_gpiod, !enable); + gpiod_set_value_cansleep(spi->cs_gpiod, + !enable); else - gpio_set_value(spi->cs_gpio, !enable); + gpio_set_value_cansleep(spi->cs_gpio, !enable); } /* Some SPI masters need both GPIO CS & slave_select */ if ((spi->controller->flags & SPI_MASTER_GPIO_SS) &&