| Message ID | 20191212231213.29061-1-jquinlan@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | spi: bcm2835: don't print error on clk_get() DEFER | expand |
On Thu, 2019-12-12 at 18:12 -0500, Jim Quinlan wrote: > Otherwise one may get multiple error messages for normal > operation of a clock provider. > > Signed-off-by: Jim Quinlan <jquinlan@broadcom.com> > --- Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
On Thu, Dec 12, 2019 at 06:12:13PM -0500, Jim Quinlan wrote: > Otherwise one may get multiple error messages for normal > operation of a clock provider. > if (IS_ERR(bs->clk)) { > err = PTR_ERR(bs->clk); > - dev_err(&pdev->dev, "could not get clk: %d\n", err); > + if (err != -EPROBE_DEFER) > + dev_err(&pdev->dev, "could not get clk: %d\n", err); On the other hand if the clock isn't there and never appears then there won't be anything saying why the driver isn't loading which won't be helpful when trying to figure out what's going on.
On Fri, Dec 13, 2019 at 6:41 AM Mark Brown <broonie@kernel.org> wrote: > > On Thu, Dec 12, 2019 at 06:12:13PM -0500, Jim Quinlan wrote: > > Otherwise one may get multiple error messages for normal > > operation of a clock provider. > > > if (IS_ERR(bs->clk)) { > > err = PTR_ERR(bs->clk); > > - dev_err(&pdev->dev, "could not get clk: %d\n", err); > > + if (err != -EPROBE_DEFER) > > + dev_err(&pdev->dev, "could not get clk: %d\n", err); > > On the other hand if the clock isn't there and never appears then there > won't be anything saying why the driver isn't loading which won't be > helpful when trying to figure out what's going on. Understood; I could do a dev_dbg() on -EPROBE_DEFER and dev_err() on all other errors -- would that work for you?
On Fri, Dec 13, 2019 at 10:33:41AM -0500, Jim Quinlan wrote: > Understood; I could do a dev_dbg() on -EPROBE_DEFER and dev_err() on > all other errors -- would that work for you? Yes, that sounds good.
diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c index fb61a620effc..6c9addc9f276 100644 --- a/drivers/spi/spi-bcm2835.c +++ b/drivers/spi/spi-bcm2835.c @@ -1305,7 +1305,8 @@ static int bcm2835_spi_probe(struct platform_device *pdev) bs->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(bs->clk)) { err = PTR_ERR(bs->clk); - dev_err(&pdev->dev, "could not get clk: %d\n", err); + if (err != -EPROBE_DEFER) + dev_err(&pdev->dev, "could not get clk: %d\n", err); goto out_controller_put; }
Otherwise one may get multiple error messages for normal operation of a clock provider. Signed-off-by: Jim Quinlan <jquinlan@broadcom.com> --- drivers/spi/spi-bcm2835.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)