diff mbox series

[v1,1/2] spi: dw: Avoid useless assignments in generic DMA setup

Message ID 20200507115449.8093-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State Accepted
Commit 140e45e1e62dd56ed4c264db1443a5d4f5f40352
Headers show
Series [v1,1/2] spi: dw: Avoid useless assignments in generic DMA setup | expand

Commit Message

Andy Shevchenko May 7, 2020, 11:54 a.m. UTC
Generic DMA setup doesn't rely on certain type of DMA controller and thus
shouldn't use Intel Medfield settings, although it's harmless in this case.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/spi/spi-dw-mid.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Mark Brown May 7, 2020, 12:43 p.m. UTC | #1
On Thu, 7 May 2020 14:54:48 +0300, Andy Shevchenko wrote:
> Generic DMA setup doesn't rely on certain type of DMA controller and thus
> shouldn't use Intel Medfield settings, although it's harmless in this case.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/spi/spi-dw-mid.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.8

Thanks!

[1/2] spi: dw: Avoid useless assignments in generic DMA setup
      commit: 140e45e1e62dd56ed4c264db1443a5d4f5f40352
[2/2] spi: dw: Get rid of dma_inited flag
      commit: a041e672cb57201d152bfc314e52d41e7643375d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/spi-dw-mid.c b/drivers/spi/spi-dw-mid.c
index f3c85f92ef12c..8b7b94c5a9ccf 100644
--- a/drivers/spi/spi-dw-mid.c
+++ b/drivers/spi/spi-dw-mid.c
@@ -321,8 +321,6 @@  static const struct dw_spi_dma_ops generic_dma_ops = {
 
 static void dw_spi_mid_setup_dma_generic(struct dw_spi *dws)
 {
-	dws->dma_tx = &mid_dma_tx;
-	dws->dma_rx = &mid_dma_rx;
 	dws->dma_ops = &generic_dma_ops;
 }
 #else	/* CONFIG_SPI_DW_MID_DMA */