| Message ID | 20200512110315.58845-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | afb7f565249aca3d46954889f07b48e8caf860ce |
| Headers | show |
| Series | [v1] spi: dw: Drop duplicate error message when remap resource | expand |
On Tue, 12 May 2020 14:03:15 +0300, Andy Shevchenko wrote: > devm_platform_ioremap_resource() will issue a message in the error case. > Thus, no need to duplicate in the driver. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.8 Thanks! [1/1] spi: dw: Drop duplicate error message when remap resource commit: afb7f565249aca3d46954889f07b48e8caf860ce All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c index bef76e210e091b..d8487209beb818 100644 --- a/drivers/spi/spi-dw-mmio.c +++ b/drivers/spi/spi-dw-mmio.c @@ -148,10 +148,8 @@ static int dw_spi_mmio_probe(struct platform_device *pdev) /* Get basic io resource and map it */ dws->regs = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(dws->regs)) { - dev_err(&pdev->dev, "SPI region map failed\n"); + if (IS_ERR(dws->regs)) return PTR_ERR(dws->regs); - } dws->irq = platform_get_irq(pdev, 0); if (dws->irq < 0)
devm_platform_ioremap_resource() will issue a message in the error case. Thus, no need to duplicate in the driver. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/spi/spi-dw-mmio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)