diff mbox series

spi: img-spfi: add missing pm_runtime_pu

Message ID 20200602054619.4352-1-navid.emamdoost@gmail.com (mailing list archive)
State New, archived
Headers show
Series spi: img-spfi: add missing pm_runtime_pu | expand

Commit Message

Navid Emamdoost June 2, 2020, 5:46 a.m. UTC
Call to pm_runtime_get_sync increments counter even in case of
failure leading to incorrect ref count.
Call pm_runtime_put if pm_runtime_get_sync fails.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
 drivers/spi/spi-img-spfi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/spi/spi-img-spfi.c b/drivers/spi/spi-img-spfi.c
index 8543f5ed1099..c3d0452ac78a 100644
--- a/drivers/spi/spi-img-spfi.c
+++ b/drivers/spi/spi-img-spfi.c
@@ -785,8 +785,10 @@  static int img_spfi_resume(struct device *dev)
 	int ret;
 
 	ret = pm_runtime_get_sync(dev);
-	if (ret)
+	if (ret) {
+		pm_runtime_put(dev);
 		return ret;
+	}
 	spfi_reset(spfi);
 	pm_runtime_put(dev);