| Message ID | 20200707131607.2.I3c56d655737c89bd9b766567a04b0854db1a4152@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: spi-qcom-qspi: Avoid some per-transfer overhead | expand |
On Tue, Jul 07, 2020 at 01:16:41PM -0700, Douglas Anderson wrote: > In commit cff80645d6d3 ("spi: spi-qcom-qspi: Add interconnect support") > the spi_geni_runtime_suspend() and spi_geni_runtime_resume() > became a bit slower. Measuring on my hardware I see numbers in the > hundreds of microseconds now. Acked-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index 322b88c22a86..6c39b23222b8 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -553,6 +553,8 @@ static int qcom_qspi_probe(struct platform_device *pdev) goto exit_probe_master_put; } + pm_runtime_use_autosuspend(dev); + pm_runtime_set_autosuspend_delay(dev, 250); pm_runtime_enable(dev); ret = spi_register_master(master);
In commit cff80645d6d3 ("spi: spi-qcom-qspi: Add interconnect support") the spi_geni_runtime_suspend() and spi_geni_runtime_resume() became a bit slower. Measuring on my hardware I see numbers in the hundreds of microseconds now. Let's use autosuspend to help avoid some of the overhead. Now if we're doing a bunch of transfers we won't need to be constantly chruning. The number 250 ms for the autosuspend delay was picked a bit arbitrarily, so if someone has measurements showing a better value we could easily change this. Fixes: cff80645d6d3 ("spi: spi-qcom-qspi: Add interconnect support") Signed-off-by: Douglas Anderson <dianders@chromium.org> --- This patch could go through the SPI tree or land in the Qualcomm tree. The patch it Fixes is currently in the Qualcomm tree so if it lands in the main SPI tree there'd be a bit of a perf regression in the Qualcomm tree until things merge together in mainline. drivers/spi/spi-qcom-qspi.c | 2 ++ 1 file changed, 2 insertions(+)