| Message ID | 20200909094304.GA420136@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c170a5a3b6944ad8e76547c4a1d9fe81c8f23ac8 |
| Headers | show |
| Series | spi: stm32: fix pm_runtime_get_sync() error checking | expand |
Hi Dan, Thanks for the patch. On Wed, Sep 09, 2020 at 12:43:04PM +0300, Dan Carpenter wrote: > The pm_runtime_get_sync() can return either 0 or 1 on success but this > code treats 1 as a failure. > > Fixes: db96bf976a4f ("spi: stm32: fixes suspend/resume management") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Alain Volmat <alain.volmat@st.com> > --- > drivers/spi/spi-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c > index d4b33b358a31..19064df42d25 100644 > --- a/drivers/spi/spi-stm32.c > +++ b/drivers/spi/spi-stm32.c > @@ -2060,7 +2060,7 @@ static int stm32_spi_resume(struct device *dev) > } > > ret = pm_runtime_get_sync(dev); > - if (ret) { > + if (ret < 0) { > dev_err(dev, "Unable to power device:%d\n", ret); > return ret; > } > -- > 2.28.0 >
On Wed, 9 Sep 2020 12:43:04 +0300, Dan Carpenter wrote: > The pm_runtime_get_sync() can return either 0 or 1 on success but this > code treats 1 as a failure. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: stm32: fix pm_runtime_get_sync() error checking commit: c170a5a3b6944ad8e76547c4a1d9fe81c8f23ac8 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index d4b33b358a31..19064df42d25 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -2060,7 +2060,7 @@ static int stm32_spi_resume(struct device *dev) } ret = pm_runtime_get_sync(dev); - if (ret) { + if (ret < 0) { dev_err(dev, "Unable to power device:%d\n", ret); return ret; }
The pm_runtime_get_sync() can return either 0 or 1 on success but this code treats 1 as a failure. Fixes: db96bf976a4f ("spi: stm32: fixes suspend/resume management") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/spi/spi-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)