| Message ID | 20210112001301.687628-1-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | eaecba8767835783bdd2f4e72406668cda7d8d54 |
| Headers | show |
| Series | [v2] spi: spi-qcom-qspi: Use irq trigger flags from firmware | expand |
Hi, On Mon, Jan 11, 2021 at 4:13 PM Stephen Boyd <swboyd@chromium.org> wrote: > > We don't need to force this to be trigger high here, as the firmware > properly configures the irq flags already. Drop it to save a line. > > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Rajendra Nayak <rnayak@codeaurora.org> > Cc: Mukesh Kumar Savaliya <msavaliy@codeaurora.org> > Cc: Akash Asthana <akashast@codeaurora.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > > Changes from v1: > * Rebased onto v5.11-rc1 > > drivers/spi/spi-qcom-qspi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Mon, 11 Jan 2021 16:13:01 -0800, Stephen Boyd wrote: > We don't need to force this to be trigger high here, as the firmware > properly configures the irq flags already. Drop it to save a line. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-qcom-qspi: Use irq trigger flags from firmware commit: eaecba8767835783bdd2f4e72406668cda7d8d54 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index 8863be370884..1dbcc410cd35 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -511,8 +511,7 @@ static int qcom_qspi_probe(struct platform_device *pdev) ret = platform_get_irq(pdev, 0); if (ret < 0) return ret; - ret = devm_request_irq(dev, ret, qcom_qspi_irq, - IRQF_TRIGGER_HIGH, dev_name(dev), ctrl); + ret = devm_request_irq(dev, ret, qcom_qspi_irq, 0, dev_name(dev), ctrl); if (ret) { dev_err(dev, "Failed to request irq %d\n", ret); return ret;
We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line. Cc: Douglas Anderson <dianders@chromium.org> Cc: Rajendra Nayak <rnayak@codeaurora.org> Cc: Mukesh Kumar Savaliya <msavaliy@codeaurora.org> Cc: Akash Asthana <akashast@codeaurora.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- Changes from v1: * Rebased onto v5.11-rc1 drivers/spi/spi-qcom-qspi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e