From patchwork Tue Jan 12 00:13:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12011789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CFFCC433DB for ; Tue, 12 Jan 2021 00:27:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE51C22D58 for ; Tue, 12 Jan 2021 00:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731000AbhALA0F (ORCPT ); Mon, 11 Jan 2021 19:26:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404242AbhALANo (ORCPT ); Mon, 11 Jan 2021 19:13:44 -0500 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5AC7C061794 for ; Mon, 11 Jan 2021 16:13:03 -0800 (PST) Received: by mail-pf1-x42a.google.com with SMTP id d2so288013pfq.5 for ; Mon, 11 Jan 2021 16:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=O0LU5ZswwTCJKm0ifYQA74K9PKuPMTkTpEKcptV47c8=; b=fTRWWqx9e8Az3Is+SwJeweEueiHH1K6iIJWo+y6HcsWR7NYRY0e7X0OW88ialGbn6r SRw3Vokb/9Ic/nebzngGm0cOV9lR5mereHanT53ruvCPacYpLG67oRMsffthEXUQYuak bOoad+2qkXMXFNtiLJZg/D/dVy0X5tXAfvQfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=O0LU5ZswwTCJKm0ifYQA74K9PKuPMTkTpEKcptV47c8=; b=l95HOV1WC+tkPN4tj1kkFHTGJFxssZofbdG0ImR3WaFhhrghk0ump/KSMIor8dB4so cHCDqh1TpZRpnVRUYR5bw6UKJWcY44dMUSMzgL6Fp8btACHi7bvUgLh0j1HaqQrpprAM d2T92P8aehcKysNLasFJ0XxUBFtTQ/Be+ZYdcR1m8wh/m8fSET6hIIBHHSrCLNqSpUTL FgkYEbwwMImzS5XW4ODMWgcRssPY2gRyEPqq71KPO8+foVdikrfzfaa2C6VXq3aJfAUW bIeYDgEu4ugLQpaJ9L3F5YxJi7VAhoE1kQJ2WkXCe/KSXcGm+rOQ1qyOMx+/HiY5sQLR 7EFQ== X-Gm-Message-State: AOAM5300ucpNPpdivsk9oqX1LezvKq+0yyJhNdMDuNTPC8V1myDrBQlL kK+zrdIXWU7ixtWA13K0BjuhYg== X-Google-Smtp-Source: ABdhPJzl19kwY6GZo/KlpQ5s+4aLpeSkGxR+LgQ4X8j2U29ON0ID5doeXzjRwTwK6v8H4uBA9iAh4A== X-Received: by 2002:aa7:8708:0:b029:19e:924:345a with SMTP id b8-20020aa787080000b029019e0924345amr1867834pfo.54.1610410383239; Mon, 11 Jan 2021 16:13:03 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:201:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id a131sm820570pfd.171.2021.01.11.16.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 16:13:02 -0800 (PST) From: Stephen Boyd To: Mark Brown Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Douglas Anderson , Rajendra Nayak , Mukesh Kumar Savaliya , Akash Asthana Subject: [PATCH v2] spi: spi-qcom-qspi: Use irq trigger flags from firmware Date: Mon, 11 Jan 2021 16:13:01 -0800 Message-Id: <20210112001301.687628-1-swboyd@chromium.org> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org We don't need to force this to be trigger high here, as the firmware properly configures the irq flags already. Drop it to save a line. Cc: Douglas Anderson Cc: Rajendra Nayak Cc: Mukesh Kumar Savaliya Cc: Akash Asthana Signed-off-by: Stephen Boyd Reviewed-by: Douglas Anderson --- Changes from v1: * Rebased onto v5.11-rc1 drivers/spi/spi-qcom-qspi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index 8863be370884..1dbcc410cd35 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -511,8 +511,7 @@ static int qcom_qspi_probe(struct platform_device *pdev) ret = platform_get_irq(pdev, 0); if (ret < 0) return ret; - ret = devm_request_irq(dev, ret, qcom_qspi_irq, - IRQF_TRIGGER_HIGH, dev_name(dev), ctrl); + ret = devm_request_irq(dev, ret, qcom_qspi_irq, 0, dev_name(dev), ctrl); if (ret) { dev_err(dev, "Failed to request irq %d\n", ret); return ret;