diff mbox series

[08/10] dt-bindings: phy: Add compatible for Mediatek MT8195

Message ID 20210316111443.3332-9-seiya.wang@mediatek.com (mailing list archive)
State New
Headers show
Series Add basic node support for Mediatek MT8195 SoC | expand

Commit Message

Seiya Wang March 16, 2021, 11:14 a.m. UTC
This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC
Platform.

Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
---
 Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Vinod Koul March 17, 2021, 6:40 a.m. UTC | #1
On 16-03-21, 19:14, Seiya Wang wrote:
> This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC
> Platform.

Applied, thanks
Chunfeng Yun March 18, 2021, 2:19 a.m. UTC | #2
On Tue, 2021-03-16 at 19:14 +0800, Seiya Wang wrote:
> This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC
> Platform.
> 
> Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> ---
>  Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> index 3a9be82e7f13..5235b1a0d188 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> @@ -22,6 +22,7 @@ properties:
>      pattern: "^ufs-phy@[0-9a-f]+$"
>  
>    compatible:
> +    enum: mediatek,mt8195-ufsphy
>      const: mediatek,mt8183-ufsphy
>  
There is warning when I make dt_binding_check, if mt8195 is compatible
with mt8183, will add it as following:

    oneOf:
      - items:
          - enum:
              - mediatek,mt8195-ufsphy
          - const: mediatek,mt8183-ufsphy
      - const: mediatek,mt8183-ufsphy

Due to Vinod already apply this patch, I'll send out a fix patch later

Thanks

>    reg:
Chunfeng Yun March 18, 2021, 2:33 a.m. UTC | #3
Hi Vinod,

On Wed, 2021-03-17 at 12:10 +0530, Vinod Koul wrote:
> On 16-03-21, 19:14, Seiya Wang wrote:
> > This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC
> > Platform.
> 
> Applied, thanks

Usually, we expect the dt-binding patch is acked or reviewed by Rob
before it's applied?

Thanks a lot

>
Seiya Wang March 18, 2021, 6:04 a.m. UTC | #4
On Thu, 2021-03-18 at 10:19 +0800, Chunfeng Yun wrote:
> On Tue, 2021-03-16 at 19:14 +0800, Seiya Wang wrote:
> > This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC
> > Platform.
> > 
> > Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> > index 3a9be82e7f13..5235b1a0d188 100644
> > --- a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> > @@ -22,6 +22,7 @@ properties:
> >      pattern: "^ufs-phy@[0-9a-f]+$"
> >  
> >    compatible:
> > +    enum: mediatek,mt8195-ufsphy
> >      const: mediatek,mt8183-ufsphy
> >  
> There is warning when I make dt_binding_check, if mt8195 is compatible
> with mt8183, will add it as following:
> 
>     oneOf:
>       - items:
>           - enum:
>               - mediatek,mt8195-ufsphy
>           - const: mediatek,mt8183-ufsphy
>       - const: mediatek,mt8183-ufsphy
> 
> Due to Vinod already apply this patch, I'll send out a fix patch later
> 
> Thanks

I will update the patch after a new linux-next tag available.
Thank you very much.

> >    reg:
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
index 3a9be82e7f13..5235b1a0d188 100644
--- a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
@@ -22,6 +22,7 @@  properties:
     pattern: "^ufs-phy@[0-9a-f]+$"
 
   compatible:
+    enum: mediatek,mt8195-ufsphy
     const: mediatek,mt8183-ufsphy
 
   reg: