| Message ID | 20210904013140.2377609-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 44ea62813f0ab3d718de480504f4dfd0bdd01858 |
| Headers | show |
| Series | ptp: don't include ptp_clock_kernel.h in spi.h | expand |
On Fri, Sep 03, 2021 at 06:31:40PM -0700, Jakub Kicinski wrote: > Commit b42faeee718c ("spi: Add a PTP system timestamp > to the transfer structure") added an include of ptp_clock_kernel.h > to spi.h for struct ptp_system_timestamp but a forward declaration > is enough. Let's use that to limit the number of objects we have > to rebuild every time we touch networking headers. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
On Fri, Sep 03, 2021 at 06:31:40PM -0700, Jakub Kicinski wrote: > Commit b42faeee718c ("spi: Add a PTP system timestamp > to the transfer structure") added an include of ptp_clock_kernel.h Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Mon, 6 Sep 2021 12:30:12 +0100 Mark Brown wrote: > On Fri, Sep 03, 2021 at 06:31:40PM -0700, Jakub Kicinski wrote: > > Commit b42faeee718c ("spi: Add a PTP system timestamp > > to the transfer structure") added an include of ptp_clock_kernel.h > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. Mark, was this ever applied? I don't see it in linux-next.
On Thu, Jan 06, 2022 at 07:56:21PM -0800, Jakub Kicinski wrote: > On Mon, 6 Sep 2021 12:30:12 +0100 Mark Brown wrote: > > Please submit patches using subject lines reflecting the style for the > > subsystem, this makes it easier for people to identify relevant patches. > > Look at what existing commits in the area you're changing are doing and > > make sure your subject lines visually resemble what they're doing. > > There's no need to resubmit to fix this alone. > Mark, was this ever applied? I don't see it in linux-next. If it's not in -next it's not been applied. This is one of the hazards of sending things with random subject lines, they get buried and missed much more easily... Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
On Fri, 7 Jan 2022 12:32:25 +0000 Mark Brown wrote: > On Thu, Jan 06, 2022 at 07:56:21PM -0800, Jakub Kicinski wrote: > > On Mon, 6 Sep 2021 12:30:12 +0100 Mark Brown wrote: > > > > Please submit patches using subject lines reflecting the style for the > > > subsystem, this makes it easier for people to identify relevant patches. > > > Look at what existing commits in the area you're changing are doing and > > > make sure your subject lines visually resemble what they're doing. > > > There's no need to resubmit to fix this alone. > > > Mark, was this ever applied? I don't see it in linux-next. > > If it's not in -next it's not been applied. This is one of the hazards > of sending things with random subject lines, they get buried and missed > much more easily... > > Please don't send content free pings and please allow a reasonable time > for review. People get busy, go on holiday, attend conferences and so > on so unless there is some reason for urgency (like critical bug fixes) > please allow at least a couple of weeks for review. If there have been > review comments then people may be waiting for those to be addressed. > > Sending content free pings adds to the mail volume (if they are seen at > all) which is often the problem and since they can't be reviewed > directly if something has gone wrong you'll have to resend the patches > anyway, so sending again is generally a better approach though there are > some other maintainers who like them - if in doubt look at how patches > for the subsystem are normally handled. I think it's best if I take this patch via networking, then. It's trivial and the merge window is afoot, anyway.
On Fri, Jan 07, 2022 at 07:50:07AM -0800, Jakub Kicinski wrote: > On Fri, 7 Jan 2022 12:32:25 +0000 Mark Brown wrote: > > Sending content free pings adds to the mail volume (if they are seen at > > all) which is often the problem and since they can't be reviewed > > directly if something has gone wrong you'll have to resend the patches > > anyway, so sending again is generally a better approach though there are > > some other maintainers who like them - if in doubt look at how patches > > for the subsystem are normally handled. > I think it's best if I take this patch via networking, then. It's > trivial and the merge window is afoot, anyway. No, it's a random cleanup that doesn't touch networking at all, only SPI. No reason for it to bypass anything.
On Fri, 3 Sep 2021 18:31:40 -0700, Jakub Kicinski wrote: > Commit b42faeee718c ("spi: Add a PTP system timestamp > to the transfer structure") added an include of ptp_clock_kernel.h > to spi.h for struct ptp_system_timestamp but a forward declaration > is enough. Let's use that to limit the number of objects we have > to rebuild every time we touch networking headers. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] ptp: don't include ptp_clock_kernel.h in spi.h commit: 44ea62813f0ab3d718de480504f4dfd0bdd01858 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 65d14af9c015..fc778492d254 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -33,6 +33,7 @@ #include <linux/highmem.h> #include <linux/idr.h> #include <linux/platform_data/x86/apple.h> +#include <linux/ptp_clock_kernel.h> #define CREATE_TRACE_POINTS #include <trace/events/spi.h> diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index 8371bca13729..31f05dd27a6d 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h @@ -14,12 +14,12 @@ #include <linux/completion.h> #include <linux/scatterlist.h> #include <linux/gpio/consumer.h> -#include <linux/ptp_clock_kernel.h> #include <uapi/linux/spi/spi.h> struct dma_chan; struct software_node; +struct ptp_system_timestamp; struct spi_controller; struct spi_transfer; struct spi_controller_mem_ops;
Commit b42faeee718c ("spi: Add a PTP system timestamp to the transfer structure") added an include of ptp_clock_kernel.h to spi.h for struct ptp_system_timestamp but a forward declaration is enough. Let's use that to limit the number of objects we have to rebuild every time we touch networking headers. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- drivers/spi/spi.c | 1 + include/linux/spi/spi.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)