| Message ID | 20211011132754.2479853-4-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Make some spi device drivers return zero in .remove() | expand |
> -----Original Message----- > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Sent: Montag, 11. Oktober 2021 15:28 > To: Dmitry Torokhov <dmitry.torokhov@gmail.com>; Hennerich, Michael > <Michael.Hennerich@analog.com> > Cc: Mark Brown <broonie@kernel.org>; linux-spi@vger.kernel.org; > kernel@pengutronix.de; linux-input@vger.kernel.org > Subject: [PATCH 03/13] hwmon: max31722: Warn about failure to put device in > stand-by in .remove() > > When an spi driver's remove function returns a non-zero error code nothing > happens apart from emitting a generic error message. Make this error message > more device specific and return zero instead. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Michael Hennerich <michael.hennerich@analog.com> > --- > drivers/hwmon/max31722.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwmon/max31722.c b/drivers/hwmon/max31722.c index > 613338cbcb17..4cf4fe6809a3 100644 > --- a/drivers/hwmon/max31722.c > +++ b/drivers/hwmon/max31722.c > @@ -103,10 +103,16 @@ static int max31722_probe(struct spi_device *spi) > static int max31722_remove(struct spi_device *spi) { > struct max31722_data *data = spi_get_drvdata(spi); > + int ret; > > hwmon_device_unregister(data->hwmon_dev); > > - return max31722_set_mode(data, MAX31722_MODE_STANDBY); > + ret = max31722_set_mode(data, MAX31722_MODE_STANDBY); > + if (ret) > + /* There is nothing we can do about this ... */ > + dev_warn(&spi->dev, "Failed to put device in stand-by > mode\n"); > + > + return 0; > } > > static int __maybe_unused max31722_suspend(struct device *dev) > -- > 2.30.2
diff --git a/drivers/hwmon/max31722.c b/drivers/hwmon/max31722.c index 613338cbcb17..4cf4fe6809a3 100644 --- a/drivers/hwmon/max31722.c +++ b/drivers/hwmon/max31722.c @@ -103,10 +103,16 @@ static int max31722_probe(struct spi_device *spi) static int max31722_remove(struct spi_device *spi) { struct max31722_data *data = spi_get_drvdata(spi); + int ret; hwmon_device_unregister(data->hwmon_dev); - return max31722_set_mode(data, MAX31722_MODE_STANDBY); + ret = max31722_set_mode(data, MAX31722_MODE_STANDBY); + if (ret) + /* There is nothing we can do about this ... */ + dev_warn(&spi->dev, "Failed to put device in stand-by mode\n"); + + return 0; } static int __maybe_unused max31722_suspend(struct device *dev)
When an spi driver's remove function returns a non-zero error code nothing happens apart from emitting a generic error message. Make this error message more device specific and return zero instead. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/hwmon/max31722.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)