| Message ID | 20211025015156.33133-5-brad@pensando.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support Pensando Elba SoC | expand |
On Sun, 24 Oct 2021 18:51:49 -0700, Brad Larson wrote: > Document the cadence qspi controller compatible for Pensando Elba SoC > boards. The Elba qspi fifo size is 1024. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
Hello Brad The patch name "dt-bindings: spi: Add compatible for Pensando Elba SoC" doesn't mention to what bindings it is referring to. For the sake of having a more representative git log I'd suggest at least to add "cdns" vendor name in the title, like: "dt-bindings: spi: cdns: Add ..." Otherwise it's impossible to understand to what bindings you're adding a new compatibility especially seeing you are doing the similar thing for the DW SPI in the next patch. -Sergey On Sun, Oct 24, 2021 at 06:51:49PM -0700, Brad Larson wrote: > Document the cadence qspi controller compatible for Pensando Elba SoC > boards. The Elba qspi fifo size is 1024. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > index 0e7087cc8bf9..d4413eced17a 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > @@ -20,6 +20,7 @@ properties: > - ti,k2g-qspi > - ti,am654-ospi > - intel,lgm-qspi > + - pensando,elba-qspi > - const: cdns,qspi-nor > - const: cdns,qspi-nor > > @@ -38,7 +39,7 @@ properties: > description: > Size of the data FIFO in words. > $ref: "/schemas/types.yaml#/definitions/uint32" > - enum: [ 128, 256 ] > + enum: [ 128, 256, 1024 ] > default: 128 > > cdns,fifo-width: > -- > 2.17.1 >
Hi Sergey, On Thu, Oct 28, 2021 at 12:26 AM Serge Semin <fancer.lancer@gmail.com> wrote: > > Hello Brad > > The patch name "dt-bindings: spi: Add compatible for Pensando Elba > SoC" doesn't mention to what bindings it is referring to. For the sake > of having a more representative git log I'd suggest at least to add > "cdns" vendor name in the title, like: "dt-bindings: spi: cdns: Add ..." > Otherwise it's impossible to understand to what bindings you're adding > a new compatibility especially seeing you are doing the similar thing > for the DW SPI in the next patch. I'll add "cdns" to the git log for the re-spin. Thanks Brad
diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml index 0e7087cc8bf9..d4413eced17a 100644 --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml @@ -20,6 +20,7 @@ properties: - ti,k2g-qspi - ti,am654-ospi - intel,lgm-qspi + - pensando,elba-qspi - const: cdns,qspi-nor - const: cdns,qspi-nor @@ -38,7 +39,7 @@ properties: description: Size of the data FIFO in words. $ref: "/schemas/types.yaml#/definitions/uint32" - enum: [ 128, 256 ] + enum: [ 128, 256, 1024 ] default: 128 cdns,fifo-width:
Document the cadence qspi controller compatible for Pensando Elba SoC boards. The Elba qspi fifo size is 1024. Signed-off-by: Brad Larson <brad@pensando.io> --- Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)