| Message ID | 20211108093153.63792-2-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 367cefbaed42eac9e1da5cc88f3b9220afc2db4d |
| Headers | show |
| Series | [1/4] mtd: dataflash: Warn about failure to unregister mtd device | expand |
On Mon, 2021-11-08 at 09:31:50 UTC, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= wrote: > mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow. > > This matches how other drivers (e.g. nand/raw/nandsim.c) use > mtd_device_unregister(). > > By returning 0 in the spi remove callback a generic error message by the > spi framework (and nothing else) is suppressed. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel
diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c index 77c872fd3d83..a8b31bddf14b 100644 --- a/drivers/mtd/devices/mchp23k256.c +++ b/drivers/mtd/devices/mchp23k256.c @@ -213,7 +213,9 @@ static int mchp23k256_remove(struct spi_device *spi) { struct mchp23k256_flash *flash = spi_get_drvdata(spi); - return mtd_device_unregister(&flash->mtd); + WARN_ON(mtd_device_unregister(&flash->mtd)); + + return 0; } static const struct of_device_id mchp23k256_of_table[] = {
mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow. This matches how other drivers (e.g. nand/raw/nandsim.c) use mtd_device_unregister(). By returning 0 in the spi remove callback a generic error message by the spi framework (and nothing else) is suppressed. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mtd/devices/mchp23k256.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)