From patchwork Thu Dec 2 16:24:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Binding X-Patchwork-Id: 12653099 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 703E5C4332F for ; Thu, 2 Dec 2021 16:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359423AbhLBQ2d (ORCPT ); Thu, 2 Dec 2021 11:28:33 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:11990 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1347508AbhLBQ2c (ORCPT ); Thu, 2 Dec 2021 11:28:32 -0500 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1B21RQLj001056; Thu, 2 Dec 2021 10:24:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=HgsqgsBHa3o1t6IcTiy7koTbQrYwrYq5EqnRuh/dMAw=; b=PSXQubl0KohNC4QZDgHQ4HU16En3EOa+0D1lmS72Cxo3ossICCXzPyd9Tn9HWuV3CN8Z nSMyKqD/IciKX1wFTPB/QxMr37apQ94SlPvKEHKEoesznGzGS1e3MRqLIU61ml2wroNg nJ0pD0YIB9OIsHJFp6mgdBZ6UyGeQpZXljany3eim/jiZFHBZYBp7L48ZOJBS/8ukyiM OAw4yLrq+MKqcSFtVHLdK1d7DtKnuybOjvo4CoU8El4yO6f49vapO31RjivNBVcV7dmT USzIO6wstMIrc0jqxGeIBocW7m9rCJuvbOFso/cMcC31QY8Lw5fmVF33c2ToWYDNNUTn lw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3cp6c89wp5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 02 Dec 2021 10:24:59 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Thu, 2 Dec 2021 16:24:57 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Thu, 2 Dec 2021 16:24:57 +0000 Received: from LONN2DGDQ73.ad.cirrus.com (unknown [198.90.238.136]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 3992D475; Thu, 2 Dec 2021 16:24:57 +0000 (UTC) From: Stefan Binding To: Mark Brown , "Rafael J . Wysocki" , Len Brown , Hans de Goede , Mark Gross CC: , , , , , Stefan Binding Subject: [PATCH 2/3] spi: Make spi_alloc_device and spi_add_device public again Date: Thu, 2 Dec 2021 16:24:20 +0000 Message-ID: <20211202162421.7628-2-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211202162421.7628-1-sbinding@opensource.cirrus.com> References: <20211202162421.7628-1-sbinding@opensource.cirrus.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: U2pXAwrv201fVDq3keUN-Ur5yeWtXZjZ X-Proofpoint-GUID: U2pXAwrv201fVDq3keUN-Ur5yeWtXZjZ X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org This functions were previously made private since they were not used. However, these functions will be needed again. Partial revert of commit da21fde0fdb3 ("spi: Make several public functions private to spi.c") Signed-off-by: Stefan Binding --- drivers/spi/spi.c | 6 ++++-- include/linux/spi/spi.h | 12 ++++++++++++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 7c81173edb0c..ebce296662c4 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -531,7 +531,7 @@ static DEFINE_MUTEX(board_lock); * * Return: a pointer to the new device, or NULL. */ -static struct spi_device *spi_alloc_device(struct spi_controller *ctlr) +struct spi_device *spi_alloc_device(struct spi_controller *ctlr) { struct spi_device *spi; @@ -556,6 +556,7 @@ static struct spi_device *spi_alloc_device(struct spi_controller *ctlr) device_initialize(&spi->dev); return spi; } +EXPORT_SYMBOL_GPL(spi_alloc_device); static void spi_dev_set_name(struct spi_device *spi) { @@ -651,7 +652,7 @@ static int __spi_add_device(struct spi_device *spi) * * Return: 0 on success; negative errno on failure */ -static int spi_add_device(struct spi_device *spi) +int spi_add_device(struct spi_device *spi) { struct spi_controller *ctlr = spi->controller; struct device *dev = ctlr->dev.parent; @@ -672,6 +673,7 @@ static int spi_add_device(struct spi_device *spi) mutex_unlock(&ctlr->add_lock); return status; } +EXPORT_SYMBOL_GPL(spi_add_device); static int spi_add_device_locked(struct spi_device *spi) { diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index 5f2781cb750f..eb348cee1c57 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h @@ -1454,7 +1454,19 @@ spi_register_board_info(struct spi_board_info const *info, unsigned n) * use spi_new_device() to describe each device. You can also call * spi_unregister_device() to start making that device vanish, but * normally that would be handled by spi_unregister_controller(). + * + * You can also use spi_alloc_device() and spi_add_device() to use a two + * stage registration sequence for each spi_device. This gives the caller + * some more control over the spi_device structure before it is registered, + * but requires that caller to initialize fields that would otherwise + * be defined using the board info. */ +extern struct spi_device * +spi_alloc_device(struct spi_controller *ctlr); + +extern int +spi_add_device(struct spi_device *spi); + extern struct spi_device * spi_new_device(struct spi_controller *, struct spi_board_info *);