| Message ID | 20220128165238.25615-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4f92724d4b92c024e721063f520d66e11ca4b54b |
| Headers | show |
| Series | spi: tegra114: Add missing IRQ check in tegra_spi_probe | expand |
On Fri, 28 Jan 2022 16:52:38 +0000, Miaoqian Lin wrote: > This func misses checking for platform_get_irq()'s call and may passes the > negative error codes to request_threaded_irq(), which takes unsigned IRQ #, > causing it to fail with -EINVAL, overriding an original error code. > Stop calling request_threaded_irq() with invalid IRQ #s. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: tegra114: Add missing IRQ check in tegra_spi_probe commit: 4f92724d4b92c024e721063f520d66e11ca4b54b All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c index e9de1d958bbd..8f345247a8c3 100644 --- a/drivers/spi/spi-tegra114.c +++ b/drivers/spi/spi-tegra114.c @@ -1352,6 +1352,10 @@ static int tegra_spi_probe(struct platform_device *pdev) tspi->phys = r->start; spi_irq = platform_get_irq(pdev, 0); + if (spi_irq < 0) { + ret = spi_irq; + goto exit_free_master; + } tspi->irq = spi_irq; tspi->clk = devm_clk_get(&pdev->dev, "spi");
This func misses checking for platform_get_irq()'s call and may passes the negative error codes to request_threaded_irq(), which takes unsigned IRQ #, causing it to fail with -EINVAL, overriding an original error code. Stop calling request_threaded_irq() with invalid IRQ #s. Fixes: f333a331adfa ("spi/tegra114: add spi driver") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/spi/spi-tegra114.c | 4 ++++ 1 file changed, 4 insertions(+)