| Message ID | 20220128165956.27821-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 47c3e06ed95aa9b74932dbc6b23b544f644faf84 |
| Headers | show |
| Series | spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe | expand |
On Fri, 28 Jan 2022 16:59:56 +0000, Miaoqian Lin wrote: > This func misses checking for platform_get_irq()'s call and may passes the > negative error codes to request_threaded_irq(), which takes unsigned IRQ #, > causing it to fail with -EINVAL, overriding an original error code. > Stop calling request_threaded_irq() with invalid IRQ #s. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe commit: 47c3e06ed95aa9b74932dbc6b23b544f644faf84 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c index ce1bdb4767ea..cb00ac2fc7d8 100644 --- a/drivers/spi/spi-tegra210-quad.c +++ b/drivers/spi/spi-tegra210-quad.c @@ -1240,6 +1240,8 @@ static int tegra_qspi_probe(struct platform_device *pdev) tqspi->phys = r->start; qspi_irq = platform_get_irq(pdev, 0); + if (qspi_irq < 0) + return qspi_irq; tqspi->irq = qspi_irq; tqspi->clk = devm_clk_get(&pdev->dev, "qspi");
This func misses checking for platform_get_irq()'s call and may passes the negative error codes to request_threaded_irq(), which takes unsigned IRQ #, causing it to fail with -EINVAL, overriding an original error code. Stop calling request_threaded_irq() with invalid IRQ #s. Fixes: 921fc1838fb0 ("spi: tegra210-quad: Add support for Tegra210 QSPI controller") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/spi/spi-tegra210-quad.c | 2 ++ 1 file changed, 2 insertions(+)